NaCl: Expose NaClApp to embedding layer.

src/trusted/service_runtime/sel_main_chrome.h

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef NATIVE_CLIENT_SRC_TRUSTED_SERVICE_RUNTIME_SEL_MAIN_CHROME_H_
 #define NATIVE_CLIENT_SRC_TRUSTED_SERVICE_RUNTIME_SEL_MAIN_CHROME_H_ 1
 
 #include "native_client/src/include/nacl_base.h"
@@ skipping 135 matching lines @@
    * that case.
    */
   size_t prereserved_sandbox_size;
 #endif
 };
 
 /* Create a new args struct containing default values. */
 struct NaClChromeMainArgs *NaClChromeMainArgsCreate(void);
 
 /* Launch NaCl. */
+struct NaClApp;
+struct NaClApp* NaClAppCreate(void);

[Mark Seaborn, 2014/01/17 16:42:06]

Why do you want to do the interface like this rather than the version from
https://code.google.com/p/chromium/issues/detail?id=333950, which was:

  struct NaClApp *NaClChromeMainCreateApp(struct NaClChromeMainArgs *args);

That seemed a little cleaner as an embedding interface because it returns a
NaClApp that is more fully initialised.

For consistency, NaClAppCreate() should be named "*Make" rather than "*Create"
(matching other functions in the NaCl codebase), and should really have a
"NaClChromeMain" prefix to match the rest of this header file.

+void NaClChromeMainStartApp(struct NaClApp *app,
+                            struct NaClChromeMainArgs *args);
+
+/* DEPRECATED. TODO(teravest): Remove. */
 void NaClChromeMainStart(struct NaClChromeMainArgs *args);
 
 
 EXTERN_C_END
 
 #endif