Issue 135853004: Partially revert "should-scroll-on-main-thread reasons if the main thread is not scrollable"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 135853004: Partially revert "should-scroll-on-main-thread reasons if the main thread is not scrollable" (Closed)

Created:
6 years, 11 months ago by Ian Vollick

Modified:
6 years, 11 months ago

Reviewers:
jamesr

CC:
blink-reviews, blink-layers+watch_chromium.org, kenneth.christiansen

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Partially revert "should-scroll-on-main-thread reasons if the main thread is not scrollable" This partially reverts r162663 (https://codereview.chromium.org/85763003). I believe the real fix is https://codereview.chromium.org/103583007/, but that solution is causing layout test failures that need to be debugged. Reverting this should get us working in the interim and the fix is not at all risky. TBR=jamesr@chromium.org BUG=303920 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165038

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -124 lines)			Patch
D	LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable.html	View	1 chunk	+0 lines, -117 lines	0 comments	Download
D	LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable-expected.txt	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/page/scrolling/ScrollingCoordinator.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/135853004/1

6 years, 11 months ago (2014-01-14 05:25:59 UTC) #1

Message was sent while issue was closed.

Change committed as 165038