Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 85763003: Ignore should-scroll-on-main-thread if main frame is not scrollable (Closed)

Created:
7 years ago by Ian Vollick
Modified:
7 years ago
CC:
blink-reviews, blink-layers+watch_chromium.org, kenneth.christiansen
Visibility:
Public.

Description

Ignore should-scroll-on-main-thread if main frame is not scrollable This change had been reverted previously because of LayoutTest flakiness. I had been concerned that this was because the code was actually incorrect, but it looks like the real problem is that we're not correctly resetting between layout tests inside Internals::resetToConsistentState. I've updated that fn and the tests are no longer flaky. This reverts commit 757a502a1b21193db4b84db6cff0703c112291ef. Review URL: https://codereview.chromium.org/76983003 BUG=321358 R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162663

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -4 lines) Patch
LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable.html View 1 chunk +117 lines, -0 lines 0 comments Download
LayoutTests/compositing/overflow/ignore-main-thread-scroll-reasons-when-main-frame-not-scrollable-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
Source/core/frame/FrameView.cpp View 1 chunk +1 line, -0 lines 0 comments Download
Source/core/page/scrolling/ScrollingCoordinator.h View 3 chunks +10 lines, -1 line 0 comments Download
Source/core/page/scrolling/ScrollingCoordinator.cpp View 6 chunks +35 lines, -3 lines 0 comments Download
Source/core/testing/Internals.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ian Vollick
Most of this is a straight reland of old code. What's new: - ScrollingCoordinator::needsToUpdateAfterCompositingChange now ...
7 years ago (2013-11-25 19:35:26 UTC) #1
Ian Vollick
On 2013/11/25 19:35:26, Ian Vollick wrote: > Most of this is a straight reland of ...
7 years ago (2013-11-25 21:58:52 UTC) #2
ojan
lgtm
7 years ago (2013-11-25 22:26:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/85763003/20001
7 years ago (2013-11-25 22:27:01 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=18668
7 years ago (2013-11-26 00:55:50 UTC) #5
Ian Vollick
7 years ago (2013-11-26 03:01:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r162663 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698