Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: media/base/video_decoder.h

Issue 13585003: GpuVideoDecoder not to use DemuxerStream after it's stopped. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/gpu_video_decoder.h » ('j') | media/filters/gpu_video_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_decoder.h
diff --git a/media/base/video_decoder.h b/media/base/video_decoder.h
index 904a6fd97823e25b691df209c8c1675da92da9cd..bc68cfa09d1d547c4df1fe97843a5f0a449bb015 100644
--- a/media/base/video_decoder.h
+++ b/media/base/video_decoder.h
@@ -59,7 +59,8 @@ class MEDIA_EXPORT VideoDecoder
// Stops decoder, fires any pending callbacks and sets the decoder to an
// uninitialized state. A VideoDecoder cannot be re-initialized after it has
- // been stopped.
+ // been stopped. A VideoDecoder should not access the DemuxerStream after it
Ami GONE FROM CHROMIUM 2013/04/04 03:43:22 This seems like a commentary on the lifecycle of t
xhwang 2013/04/04 17:05:33 Done.
+ // has been stopped.
// Note that if Initialize() has been called, Stop() must be called and
// complete before deleting the decoder.
virtual void Stop(const base::Closure& closure) = 0;
« no previous file with comments | « no previous file | media/filters/gpu_video_decoder.h » ('j') | media/filters/gpu_video_decoder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698