runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.dart - Issue 135843006: Improve Code object support in service and observatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.dart

Issue 135843006: Improve Code object support in service and observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart ('K') | « runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html » ('j') | runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_profile.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.dart

diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.dart b/runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.dart

index d342ce369dfb291ea699938845b9ea1ba9bb6b60..437882b6fcce5f9e1248a11781aa31467534ae0b 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.dart

+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.dart

@@ -5,17 +5,15 @@

library code_view_element;

import 'package:polymer/polymer.dart';

+import 'package:observatory/observatory.dart';

import 'observatory_element.dart';

@CustomTag('code-view')

class CodeViewElement extends ObservatoryElement {

- @published Map code = toObservable({});

+ @published Code code;

CodeViewElement.created() : super.created();

String get cssPanelClass {

- if (code != null && code['is_optimized'] != null) {

- return 'panel panel-success';

- }

- return 'panel panel-warning';

+ return 'panel panel-success';

}