runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html - Issue 135843006: Improve Code object support in service and observatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html

Issue 135843006: Improve Code object support in service and observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart ('K') | « runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.dart ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/disassembly_entry.dart » ('j') | runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_profile.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html

diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html b/runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html

index 8b7b6639fdb88687c86798cb1039a8b7cced4e4b..7455fa7e2c0d970dd11a39c080ba1b5c16e1e18a 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html

+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html

@@ -9,7 +9,7 @@

- <function-ref app="{{ app }}" ref="{{ code['function'] }}"></function-ref>

+ <function-ref app="{{ app }}" ref="{{ code.functionRef }}"></function-ref>

</div>

@@ -17,7 +17,7 @@

<div class="col-md-2"><strong>Address</strong></div>

<div><strong>Instruction</strong></div>

</div>

- <template repeat="{{ instruction in code['disassembly'] }}">

+ <template repeat="{{ instruction in code.instructions }}">

<disassembly-entry instruction="{{ instruction }}">

</disassembly-entry>

</template>