Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135843005: Add retries so new tab is created for sure. (Closed)

Created:
6 years, 11 months ago by achuithb
Modified:
6 years, 11 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add retries so new tab is created for sure. BUG=331940, 334726 TEST=manual NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245446

Patch Set 1 #

Patch Set 2 : raise exception after retries fail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 1 chunk +13 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
achuithb
Let me know if you have any better ideas. I think the timeout may have ...
6 years, 11 months ago (2014-01-16 22:39:08 UTC) #1
achuithb
Raising the caught exception if we run out of retries. Decreased the navigate timeout back ...
6 years, 11 months ago (2014-01-17 00:51:42 UTC) #2
achuithb
On 2014/01/17 00:51:42, achuith.bhandarkar wrote: > Raising the caught exception if we run out of ...
6 years, 11 months ago (2014-01-17 00:52:44 UTC) #3
Tim Song
lgtm
6 years, 11 months ago (2014-01-17 01:59:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/135843005/40001
6 years, 11 months ago (2014-01-17 02:02:47 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 06:45:00 UTC) #6
Message was sent while issue was closed. 
Change committed as 245446

Powered by Google App Engine
This is Rietveld 408576698