[Telemetry] Fix page_cycler for pages with client side redirects.

[Telemetry] Fix page_cycler for pages with client side redirects.

Page.disable clears all scripts to evaluate on commit. There is no way
to detect client side redirects because linkedin, for example, performs
its client side redirect after the page has fully loaded.

In order for the page_cyclers to work on pages with client side
redirects, the script to evaluate on commit must execute on the
redirected page.

So to workaround this, we avoid ever calling Page.disable. we don't
expect continuing to listen for notifications here to impact
performance, but if we do see any performance reduction on the bots we
should revert and search for another approach.

This is a reland of https://codereview.chromium.org/103373003 fixing failures
on the bots.

BUG=253604
R=pdr@chromium.org
TEST=tools/perf/run_measurement --browser=canary page_cycler tools/perf/page_sets/top_10_mobile.json --pageset-repeat=2

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243533

[qsr, 2014-01-07 14:30:12]

Hi,

 This is a reland with a small bug fix from your CL:
https://codereview.chromium.org/103373003

 Any reason you stopped working on this?

[tonyg, 2014-01-07 16:12:44]

lgtm

Let's just try it and revert again if there are problems.

Just out of curiosity, could you please point out what changed from pdr's last
patch?

[qsr, 2014-01-07 16:22:15]

Explanation added as an annotation where the code changed.

https://codereview.chromium.org/112413006/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/inspector_page.py (right):

https://codereview.chromium.org/112413006/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/inspector_page.py:23:
self._EnablePageNotifications()
Enabling notification only after setting up the variable. The error on the bots
was about some local variable not existing on this class:

Traceback (most recent call last):
  File
"/usr/local/google/home/achuith/code/chrome/src/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py",
line 243, in _HandleNotification
    self._domain_handlers[domain_name][0](res)
  File
"/usr/local/google/home/achuith/code/chrome/src/tools/telemetry/telemetry/core/backends/chrome/inspector_page.py",
line 27, in _OnNotification
    if msg['method'] == 'Page.frameNavigated' and self._navigation_pending:
AttributeError: 'InspectorPage' object has no attribute '_navigation_pending'

 I guess this can happen if a notification is sent immediately by the browser.

[commit-bot: I haz the power, 2014-01-07 16:23:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qsr@chromium.org/112413006/1

[pdr., 2014-01-07 17:54:06]

On 2014/01/07 16:23:05, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/qsr%40chromium.org/112413006/1

Fantastic! LGTM. Thank you for landing this :)

[commit-bot: I haz the power, 2014-01-07 19:24:13]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 07:59:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qsr@chromium.org/112413006/1

[commit-bot: I haz the power, 2014-01-08 12:28:44]

Change committed as 243533