Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 1358403002: [runtime] Remove obsolete Object::IsSpecFunction. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove obsolete Object::IsSpecFunction. We don't need Object::IsSpecFunction anymore, since it only checks for JSFunction and JSFunctionProxy, but what you actually want to check for (in case of accessors) is whether the target has a [[Call]] internal method, which is exactly what Object::IsCallable does. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg R=rossberg@chromium.org BUG=v8:4413 LOG=n Committed: https://crrev.com/91c495ff446363b480aee3a980dcb5006dca5692 Cr-Commit-Position: refs/heads/master@{#30875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M src/objects.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/objects-inl.h View 2 chunks +1 line, -9 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
5 years, 2 months ago (2015-09-23 04:37:32 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358403002/1
5 years, 2 months ago (2015-09-23 04:38:02 UTC) #3
Benedikt Meurer
Hey Andreas, This is trivial cleanup. Please take a look. Thanks, Benedikt
5 years, 2 months ago (2015-09-23 04:38:02 UTC) #4
rossberg
lgtm
5 years, 2 months ago (2015-09-23 05:37:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358403002/1
5 years, 2 months ago (2015-09-23 05:42:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-23 05:53:29 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 05:53:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91c495ff446363b480aee3a980dcb5006dca5692
Cr-Commit-Position: refs/heads/master@{#30875}

Powered by Google App Engine
This is Rietveld 408576698