Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/runtime/runtime-object.cc

Issue 1358403002: [runtime] Remove obsolete Object::IsSpecFunction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/bootstrapper.h" 8 #include "src/bootstrapper.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 1186 matching lines...) Expand 10 before | Expand all | Expand 10 after
1197 1197
1198 RUNTIME_FUNCTION(Runtime_IsJSGlobalProxy) { 1198 RUNTIME_FUNCTION(Runtime_IsJSGlobalProxy) {
1199 SealHandleScope shs(isolate); 1199 SealHandleScope shs(isolate);
1200 DCHECK(args.length() == 1); 1200 DCHECK(args.length() == 1);
1201 CONVERT_ARG_CHECKED(Object, obj, 0); 1201 CONVERT_ARG_CHECKED(Object, obj, 0);
1202 return isolate->heap()->ToBoolean(obj->IsJSGlobalProxy()); 1202 return isolate->heap()->ToBoolean(obj->IsJSGlobalProxy());
1203 } 1203 }
1204 1204
1205 1205
1206 static bool IsValidAccessor(Handle<Object> obj) { 1206 static bool IsValidAccessor(Handle<Object> obj) {
1207 return obj->IsUndefined() || obj->IsSpecFunction() || obj->IsNull(); 1207 return obj->IsUndefined() || obj->IsCallable() || obj->IsNull();
1208 } 1208 }
1209 1209
1210 1210
1211 // Implements part of 8.12.9 DefineOwnProperty. 1211 // Implements part of 8.12.9 DefineOwnProperty.
1212 // There are 3 cases that lead here: 1212 // There are 3 cases that lead here:
1213 // Step 4b - define a new accessor property. 1213 // Step 4b - define a new accessor property.
1214 // Steps 9c & 12 - replace an existing data property with an accessor property. 1214 // Steps 9c & 12 - replace an existing data property with an accessor property.
1215 // Step 12 - update an existing accessor property with an accessor or generic 1215 // Step 12 - update an existing accessor property with an accessor or generic
1216 // descriptor. 1216 // descriptor.
1217 RUNTIME_FUNCTION(Runtime_DefineAccessorPropertyUnchecked) { 1217 RUNTIME_FUNCTION(Runtime_DefineAccessorPropertyUnchecked) {
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
1610 RUNTIME_FUNCTION(Runtime_IsAccessCheckNeeded) { 1610 RUNTIME_FUNCTION(Runtime_IsAccessCheckNeeded) {
1611 SealHandleScope shs(isolate); 1611 SealHandleScope shs(isolate);
1612 DCHECK_EQ(1, args.length()); 1612 DCHECK_EQ(1, args.length());
1613 CONVERT_ARG_CHECKED(Object, object, 0); 1613 CONVERT_ARG_CHECKED(Object, object, 0);
1614 return isolate->heap()->ToBoolean(object->IsAccessCheckNeeded()); 1614 return isolate->heap()->ToBoolean(object->IsAccessCheckNeeded());
1615 } 1615 }
1616 1616
1617 1617
1618 } // namespace internal 1618 } // namespace internal
1619 } // namespace v8 1619 } // namespace v8
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698