Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1358203003: Normalize and update the header value checks to RFC 7230 for Fetch

Created:
5 years, 3 months ago by shiva.jm
Modified:
4 years, 1 month ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Normalize and update the header value checks to RFC 7230 for Fetch. Normalize the Header value for append() and set() api. To normalize a value, remove any leading and trailing HTTP whitespace bytes from it. HTTP whitespace bytes are 0x09, 0x0A, 0x0D, and 0x20. Intent to update header is: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/K5jd8Y5l6pI Spec link: https://fetch.spec.whatwg.org/#concept-header-value-normalize BUG=455099

Patch Set 1 #

Total comments: 9

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -26 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/fetch/resources/fetch-test-helpers.js View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchHeaderList.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp View 1 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Headers.cpp View 2 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
shiva.jm
pls have a look, these CL is merge from https://codereview.chromium.org/1288263003/. since after blink merge, we ...
5 years, 3 months ago (2015-09-24 09:09:40 UTC) #2
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/1358203003/diff/1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js (right): https://codereview.chromium.org/1358203003/diff/1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js#newcode181 third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js:181: headers.set('a', '\xd0\xa1'); why is set() used for some of ...
5 years, 2 months ago (2015-09-28 06:35:40 UTC) #3
shiva.jm
updated the patch with comments, pls have a look. https://codereview.chromium.org/1358203003/diff/1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js (right): https://codereview.chromium.org/1358203003/diff/1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js#newcode181 third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js:181: ...
5 years, 2 months ago (2015-09-28 07:01:21 UTC) #4
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/1358203003/diff/1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js (right): https://codereview.chromium.org/1358203003/diff/1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js#newcode179 third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js:179: // Tests for new valid Headers values. Tests for ...
5 years, 2 months ago (2015-09-28 08:11:58 UTC) #5
shiva.jm
updated the patch with comments, pls have a look. https://codereview.chromium.org/1358203003/diff/1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js (right): https://codereview.chromium.org/1358203003/diff/1/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js#newcode179 third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js:179: ...
5 years, 2 months ago (2015-09-28 08:56:44 UTC) #6
shiva.jm
CL: https://codereview.chromium.org/1378543002 has added UMA for header values in XHR's setRequestHeader() for RFC 7230, so ...
5 years, 2 months ago (2015-10-05 04:48:32 UTC) #7
hiroshige
On 2015/10/05 04:48:32, shiva.jm wrote: > CL: https://codereview.chromium.org/1378543002 has added UMA for header values > ...
5 years, 1 month ago (2015-10-29 12:56:51 UTC) #8
shiva.jm
On 2015/10/29 12:56:51, hiroshige wrote: > On 2015/10/05 04:48:32, shiva.jm wrote: > > CL: https://codereview.chromium.org/1378543002 ...
5 years, 1 month ago (2015-11-03 11:22:57 UTC) #9
yhirano
4 years, 1 month ago (2016-11-15 03:43:49 UTC) #11
(Removing myself from the reviewers list)

Powered by Google App Engine
This is Rietveld 408576698