Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp

Issue 1358203003: Normalize and update the header value checks to RFC 7230 for Fetch Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/fetch/FetchHeaderList.h" 6 #include "modules/fetch/FetchHeaderList.h"
7 7
8 #include "core/fetch/FetchUtils.h" 8 #include "core/fetch/FetchUtils.h"
9 #include "platform/network/HTTPParsers.h" 9 #include "platform/network/HTTPParsers.h"
10 #include "wtf/PassOwnPtr.h" 10 #include "wtf/PassOwnPtr.h"
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 return false; 142 return false;
143 } 143 }
144 144
145 bool FetchHeaderList::isValidHeaderName(const String& name) 145 bool FetchHeaderList::isValidHeaderName(const String& name)
146 { 146 {
147 // "A name is a case-insensitive byte sequence that matches the field-name 147 // "A name is a case-insensitive byte sequence that matches the field-name
148 // token production." 148 // token production."
149 return isValidHTTPToken(name); 149 return isValidHTTPToken(name);
150 } 150 }
151 151
152 bool FetchHeaderList::isValidHeaderValue(const String& value) 152 bool FetchHeaderList::isValidHeaderValueRFC7230(const String& value)
153 { 153 {
154 // "A value is a byte sequence that matches the field-value token production 154 // checks the header value according to the latest Fetch API's header
tyoshino (SeeGerritForStatus) 2015/09/28 06:35:40 checks -> Checks
shiva.jm 2015/09/28 07:01:21 Done.
155 // and contains no 0x0A or 0x0D bytes." 155 // value definition (https://fetch.spec.whatwg.org/#concept-header-value) an d RFC
156 return isValidHTTPHeaderValue(value); 156 // 7230 and it is different from isValidHTTPHeaderValue().
157
158 return value.isEmpty() || isValidHTTPFieldContentRFC7230(value);
157 } 159 }
158 160
159 } // namespace blink 161 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698