Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1358173007: Enable coordinated scrollbars in subframes and overflow scrollers. (Closed)

Created:
5 years, 2 months ago by skobes
Modified:
5 years, 2 months ago
Reviewers:
trchen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable coordinated scrollbars in subframes and overflow scrollers. This removes an obsolete main-frame-only restriction for coordinated scrollbars on certain platforms (Linux, Windows, and ChromeOS). The test rebaselines are because GraphicsLayer::m_drawsContent is now false for scrollbar layers (since the content is drawn by cc instead of Blink). BUG=535051 Committed: https://crrev.com/b55a5a20a5c8d4d322b05e392a86921048ff3524 Cr-Commit-Position: refs/heads/master@{#351620}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
skobes
5 years, 2 months ago (2015-09-29 22:02:01 UTC) #4
trchen
lgtm. Cool! If my memory is correct, only Android enabled impl-side scrollbar everywhere because back ...
5 years, 2 months ago (2015-09-30 19:10:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358173007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358173007/40001
5 years, 2 months ago (2015-09-30 19:16:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 2 months ago (2015-09-30 19:42:15 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 19:43:29 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b55a5a20a5c8d4d322b05e392a86921048ff3524
Cr-Commit-Position: refs/heads/master@{#351620}

Powered by Google App Engine
This is Rietveld 408576698