Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 1358173007: Enable coordinated scrollbars in subframes and overflow scrollers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
index 657e59e9626a8fe69f005870bdfec00ed327c69d..86e3467a4f650f16e2229eb603a78281b6a051cc 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
@@ -342,13 +342,8 @@ void ScrollingCoordinator::scrollableAreaScrollbarLayerDidChange(ScrollableArea*
// FIXME: Instead of hardcode here, we should make a setting flag.
#if OS(MACOSX)
static const bool platformSupportsCoordinatedScrollbar = ScrollAnimatorMac::canUseCoordinatedScrollbar();
- static const bool platformSupportsMainFrameOnly = false; // Don't care.
-#elif OS(ANDROID)
- static const bool platformSupportsCoordinatedScrollbar = true;
- static const bool platformSupportsMainFrameOnly = false;
#else
static const bool platformSupportsCoordinatedScrollbar = true;
- static const bool platformSupportsMainFrameOnly = true;
#endif
bool isMainFrame = isForMainFrame(scrollableArea);
@@ -356,8 +351,7 @@ void ScrollingCoordinator::scrollableAreaScrollbarLayerDidChange(ScrollableArea*
? scrollableArea->layerForHorizontalScrollbar()
: scrollableArea->layerForVerticalScrollbar();
- bool shouldCreateCoordinatedScrollbar = platformSupportsCoordinatedScrollbar && !(platformSupportsMainFrameOnly && !isMainFrame);
- if (!shouldCreateCoordinatedScrollbar) {
+ if (!platformSupportsCoordinatedScrollbar) {
if (scrollbarGraphicsLayer) {
WebLayer* scrollbarLayer = toWebLayer(scrollbarGraphicsLayer);
scrollbarLayer->setShouldScrollOnMainThread(true);
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698