Refactor HostSettings class.

Refactor HostSettings class.

There are four main changes:

* Rename HostSettings to HostOptions (since the functionality it provides was previously provided by Host.Options).
* Make all fields optional. This was in response to a comment on https://codereview.chromium.org/1343503002/ that using an empty set of remappings to represent the default doesn't make much sense. I extended it to apply to all settings.
* Move the default key remapping logic into getRemapKeys().
* Move the string->dictionary key remapping logic into setRemapKeys().

Committed: https://crrev.com/5816f58abd0d2b08d118924ed9240195a0a23716
Cr-Commit-Position: refs/heads/master@{#350886}

[Jamie, 2015-09-23 18:00:47]

jamiewalch@chromium.org changed reviewers:
+ kelvinp@chromium.org

[Jamie, 2015-09-23 18:00:47]

ptal

[kelvinp, 2015-09-23 20:02:26]

lgtm once my comments are addressed.

https://codereview.chromium.org/1358173005/diff/1/remoting/webapp/base/js/hos...
File remoting/webapp/base/js/host_options.js (right):

https://codereview.chromium.org/1358173005/diff/1/remoting/webapp/base/js/hos...
remoting/webapp/base/js/host_options.js:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
drop (c), s/2012/2015

https://codereview.chromium.org/1358173005/diff/1/remoting/webapp/base/js/hos...
remoting/webapp/base/js/host_options.js:226: function copyNonNullSettings_(to,
from) {
I think this is essentially the same as
base.copyWithoutNullFields()

https://codereview.chromium.org/1358173005/diff/1/remoting/webapp/crd/js/me2m...
File remoting/webapp/crd/js/me2me_activity.js (right):

https://codereview.chromium.org/1358173005/diff/1/remoting/webapp/crd/js/me2m...
remoting/webapp/crd/js/me2me_activity.js:370: 'sharedSecret': sharedSecret});
indent

[Jamie, 2015-09-23 20:47:13]

Please take another look. One of your suggested changes involved some churn.

https://codereview.chromium.org/1358173005/diff/1/remoting/webapp/base/js/hos...
File remoting/webapp/base/js/host_options.js (right):

https://codereview.chromium.org/1358173005/diff/1/remoting/webapp/base/js/hos...
remoting/webapp/base/js/host_options.js:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
On 2015/09/23 20:02:26, kelvinp wrote:
> drop (c), s/2012/2015

Done.

https://codereview.chromium.org/1358173005/diff/1/remoting/webapp/base/js/hos...
remoting/webapp/base/js/host_options.js:226: function copyNonNullSettings_(to,
from) {
On 2015/09/23 20:02:26, kelvinp wrote:
> I think this is essentially the same as
> base.copyWithoutNullFields()

base.copyWithoutNullFields returns a new object, which is not appropriate in the
load case (we want to merge the results into a |this| pointer). I've rewritten
it to copy into an existing object instead. WDYT?

https://codereview.chromium.org/1358173005/diff/1/remoting/webapp/crd/js/me2m...
File remoting/webapp/crd/js/me2me_activity.js (right):

https://codereview.chromium.org/1358173005/diff/1/remoting/webapp/crd/js/me2m...
remoting/webapp/crd/js/me2me_activity.js:370: 'sharedSecret': sharedSecret});
On 2015/09/23 20:02:26, kelvinp wrote:
> indent

Done.

[Jamie, 2015-09-23 22:10:09]

As discussed, I re-added copyWithoutNullFields as a helper for
mergeWithoutNullFields, which results in less churn. PTAL.

https://codereview.chromium.org/1358173005/diff/60001/remoting/webapp/base/js...
File remoting/webapp/base/js/base_unittest.js (right):

https://codereview.chromium.org/1358173005/diff/60001/remoting/webapp/base/js...
remoting/webapp/base/js/base_unittest.js:113: QUnit.test('copyWithoutNullFields
does a deep copy',
NB: This is a change in semantics from the old code, but I think it's how the
function should behave and I don't think any existing code relied on the old
semantics.

[kelvinp, 2015-09-24 21:51:02]

lgtm

[Jamie, 2015-09-24 21:51:38]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2015-09-24 21:54:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358173005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358173005/60001

[commit-bot: I haz the power, 2015-09-24 21:57:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 21:57:17]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jamie, 2015-09-25 00:34:18]

The CQ bit was checked by jamiewalch@chromium.org

[Jamie, 2015-09-25 00:34:18]

The patchset sent to the CQ was uploaded after l-g-t-m from kelvinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1358173005/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-09-25 00:35:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358173005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358173005/80001

[commit-bot: I haz the power, 2015-09-25 01:15:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 01:15:28]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jamie, 2015-09-25 16:07:16]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2015-09-25 16:07:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358173005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358173005/80001

[commit-bot: I haz the power, 2015-09-25 16:42:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 16:42:51]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Jamie, 2015-09-25 18:50:28]

The CQ bit was checked by jamiewalch@chromium.org

[Jamie, 2015-09-25 18:50:29]

The patchset sent to the CQ was uploaded after l-g-t-m from kelvinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1358173005/#ps100001
(title: "Fix unit tests.")

[commit-bot: I haz the power, 2015-09-25 18:51:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358173005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358173005/100001

[commit-bot: I haz the power, 2015-09-25 19:31:47]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-09-25 19:32:26]

Patchset 6 (id:??) landed as
https://crrev.com/5816f58abd0d2b08d118924ed9240195a0a23716
Cr-Commit-Position: refs/heads/master@{#350886}