remoting/webapp/crd/js/desktop_remoting_activity.js - Issue 1358173005: Refactor HostSettings class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/desktop_remoting_activity.js

Issue 1358173005: Refactor HostSettings class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit tests. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/webapp/crd/js/desktop_remoting_activity.js

diff --git a/remoting/webapp/crd/js/desktop_remoting_activity.js b/remoting/webapp/crd/js/desktop_remoting_activity.js

index 5b48b1e9674a25f9e02bcafd955acdddad0e35a2..b4c3a079edfa3244ab14270bf4b7fa468ec021cd 100644

--- a/remoting/webapp/crd/js/desktop_remoting_activity.js

+++ b/remoting/webapp/crd/js/desktop_remoting_activity.js

@@ -94,12 +94,8 @@ remoting.DesktopRemotingActivity.prototype.onConnected =

document.getElementById('client-container'), connectionInfo);

// Apply the default or previously-specified keyboard remapping.

- var remapping = connectionInfo.host().options.remapKeys;

- if (base.isEmptyObject(remapping) && remoting.platformIsChromeOS()) {

- // Under ChromeOS, remap the right Control key to the right Win/Cmd key.

- remapping = {0x0700e4: 0x0700e7};

- }

- connectionInfo.plugin().setRemapKeys(remapping);

+ var remapping = connectionInfo.host().options.getRemapKeys();

+ this.connectedView_.setRemapKeys(remapping);

if (connectionInfo.plugin().hasCapability(

remoting.ClientSession.Capability.VIDEO_RECORDER)) {