Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1358163006: Adds some code to help isolate where crash is happening (Closed)

Created:
5 years, 3 months ago by sky
Modified:
5 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds some code to help isolate where crash is happening I would prefer to use tracked_objects::Location for this, but we don't want mojo public apis to depend upon base. I may have to plumb something similar through if this doesn't pan out. BUG=534719 TEST=none Committed: https://crrev.com/20033018f07a6708eec6611955428dc47c4c1220 Cr-Commit-Position: refs/heads/master@{#350917}

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : order #

Patch Set 4 : order #

Patch Set 5 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -68 lines) Patch
M components/html_viewer/web_url_loader_impl.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/message_port/web_message_port_channel_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_data_consumer_handle_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/system/core_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/default_async_waiter_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/message_pump/handle_watcher.h View 3 chunks +6 lines, -1 line 0 comments Download
M mojo/message_pump/handle_watcher.cc View 7 chunks +16 lines, -11 lines 0 comments Download
M mojo/message_pump/handle_watcher_unittest.cc View 11 chunks +15 lines, -13 lines 0 comments Download
M mojo/message_pump/message_pump_mojo.h View 2 chunks +8 lines, -2 lines 0 comments Download
M mojo/message_pump/message_pump_mojo.cc View 1 2 3 5 chunks +13 lines, -1 line 0 comments Download
M mojo/message_pump/message_pump_mojo_unittest.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M mojo/services/network/http_connection_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/cpp/web_socket_read_queue.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/services/network/public/cpp/web_socket_write_queue.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/services/network/tcp_connected_socket_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/network/url_loader_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/js/drain_data.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/js/waiting_callback.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/public/c/environment/async_waiter.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/connector.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/lib/async_waiter.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/lib/default_async_waiter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/tests/async_wait_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
5 years, 2 months ago (2015-09-25 16:09:44 UTC) #2
jam
lgtm
5 years, 2 months ago (2015-09-25 19:41:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358163006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358163006/80001
5 years, 2 months ago (2015-09-25 19:44:54 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-09-25 21:25:59 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 21:26:52 UTC) #7
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/20033018f07a6708eec6611955428dc47c4c1220
Cr-Commit-Position: refs/heads/master@{#350917}

Powered by Google App Engine
This is Rietveld 408576698