third_party/mojo/src/mojo/public/c/environment/async_waiter.h - Issue 1358163006: Adds some code to help isolate where crash is happening

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/c/environment/async_waiter.h

Issue 1358163006: Adds some code to help isolate where crash is happening (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: moar Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo/src/mojo/edk/js/waiting_callback.cc ('k') | third_party/mojo/src/mojo/public/cpp/bindings/lib/connector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/public/c/environment/async_waiter.h

diff --git a/third_party/mojo/src/mojo/public/c/environment/async_waiter.h b/third_party/mojo/src/mojo/public/c/environment/async_waiter.h

index b5a1f7523fe6b329981050bdc76f2e6d35eb517a..bbb794be784bd60e5357bc9fd77620cb698d163e 100644

--- a/third_party/mojo/src/mojo/public/c/environment/async_waiter.h

+++ b/third_party/mojo/src/mojo/public/c/environment/async_waiter.h

@@ -43,7 +43,11 @@ struct MojoAsyncWaiter {

// Note that once the callback has been called, the returned |MojoAsyncWaitID|

// becomes invalid.

- MojoAsyncWaitID (*AsyncWait)(MojoHandle handle,

+ //

+ // TODO(sky): id is for tracking http://crbug.com/534719, will remove once

+ // fixed. |id| is used to identify the caller.

+ MojoAsyncWaitID (*AsyncWait)(int id,

+ MojoHandle handle,

MojoHandleSignals signals,

MojoDeadline deadline,

MojoAsyncWaitCallback callback,