Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issue 135793002: Revert 244398 "Revert of https://codereview.chromium.org/111953007/" (Closed)

Created:
6 years, 11 months ago by cmp
Modified:
6 years, 11 months ago
Reviewers:
cmp
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 244398 "Revert of https://codereview.chromium.org/111953007/" > Revert of https://codereview.chromium.org/111953007/ > Reason for revert: Broke Linux build in http://build.chromium.org/p/chromium/builders/Linux/builds/46507. > > TBR=thakis@chromium.org,ajwong@chromium.org,brettw@chromium.org,phajdan.jr@chromium.org,nick@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=240309 > > Review URL: https://codereview.chromium.org/135773002 The original patch didn't set props correctly. thakis landed a separate change to fix that. The revert of this revert in Rietveld failed at https://codereview.chromium.org/135773003/. TBR=cmp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, --10 lines) Patch
M trunk/src/.gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/DEPS View 1 chunk +34 lines, -0 lines 0 comments Download
A + trunk/src/third_party/clang_format/README.chromium View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/third_party/clang_format/README.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/third_party/clang_format/bin/linux/clang-format.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/third_party/clang_format/bin/mac/clang-format.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/third_party/clang_format/bin/win/clang-format.exe.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/third_party/clang_format/scripts/clang-format.el View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/third_party/clang_format/scripts/clang-format.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/third_party/clang_format/scripts/clang-format-bbedit.applescript View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/third_party/clang_format/scripts/clang-format-diff.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/third_party/clang_format/scripts/clang-format-sublime.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/tools/checklicenses/checklicenses.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
cmp
6 years, 11 months ago (2014-01-12 00:19:12 UTC) #1
cmp
6 years, 11 months ago (2014-01-12 00:19:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r244400.

Powered by Google App Engine
This is Rietveld 408576698