Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 135773002: Revert of Add clang-format binaries and scripts for all platforms (Closed)

Created:
6 years, 11 months ago by cmp
Modified:
6 years, 11 months ago
CC:
chromium-reviews, hinoka, awong
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -421 lines) Patch
M .gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
M DEPS View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/clang_format/README.chromium View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/clang_format/README.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/clang_format/bin/linux/clang-format.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/clang_format/bin/mac/clang-format.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/clang_format/bin/win/clang-format.exe.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/clang_format/scripts/clang-format.el View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/clang_format/scripts/clang-format.py View 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/clang_format/scripts/clang-format-bbedit.applescript View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/clang_format/scripts/clang-format-diff.py View 1 chunk +0 lines, -114 lines 0 comments Download
D third_party/clang_format/scripts/clang-format-sublime.py View 1 chunk +0 lines, -58 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
cmp
Created Revert of Add clang-format binaries and scripts for all platforms
6 years, 11 months ago (2014-01-11 23:51:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmp@chromium.org/135773002/1
6 years, 11 months ago (2014-01-11 23:51:57 UTC) #2
commit-bot: I haz the power
Change committed as 244398
6 years, 11 months ago (2014-01-11 23:52:12 UTC) #3
cmp
In failing build, check_perms failed with this output: Found subversion checkout at /b/build/slave/Linux/build/src Processed 53854 ...
6 years, 11 months ago (2014-01-11 23:56:18 UTC) #4
Nico
Oh hi, I had fixed this in http://src.chromium.org/viewvc/chrome?revision=244392&view=revision The Linux bot hasn't cycled with this ...
6 years, 11 months ago (2014-01-12 00:13:26 UTC) #5
cmp
On 2014/01/12 00:13:26, Nico wrote: > Oh hi, I had fixed this in > http://src.chromium.org/viewvc/chrome?revision=244392&view=revision ...
6 years, 11 months ago (2014-01-12 00:15:50 UTC) #6
cmp
6 years, 11 months ago (2014-01-12 00:16:12 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/135773003/ by cmp@chromium.org.

The reason for reverting is: thakis says he fixed this in a later CL.

Powered by Google App Engine
This is Rietveld 408576698