Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1357913002: Update to use third_party/webrtc_overrides instead of third_party/webrtc/overrides. (Closed)

Created:
5 years, 3 months ago by Henrik Grunell
Modified:
5 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@add_webrtc_overrides
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update to use third_party/webrtc_overrides instead of third_party/webrtc/overrides. This is one step in moving the overrides files from WebRTC to Chromium. See bug comment #65 for all steps. Depends on https://codereview.chromium.org/1345873004/ and a WebRTC roll (specifically https://codereview.webrtc.org/1345313004/). BUG=468375 Committed: https://crrev.com/d1971c56ac15008bde9caef79e90ace1113be32f Cr-Commit-Position: refs/heads/master@{#351554}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M content/renderer/media/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_logging.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M jingle/glue/logging_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libjingle/libjingle_nacl.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/overrides/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Henrik Grunell
Per: content/renderer/media/* Sergey: jingle/* Henrik K: third_party/libjingle/*
5 years, 3 months ago (2015-09-21 10:45:05 UTC) #4
kjellander_chromium
On 2015/09/21 10:45:05, Henrik Grunell wrote: > Per: content/renderer/media/* > Sergey: jingle/* > Henrik K: ...
5 years, 3 months ago (2015-09-21 10:51:01 UTC) #5
Sergey Ulanov
lgtm
5 years, 3 months ago (2015-09-21 19:02:05 UTC) #6
perkj_chrome
lgtm
5 years, 3 months ago (2015-09-22 07:30:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357913002/20001
5 years, 2 months ago (2015-09-30 13:19:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-30 14:52:50 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 14:53:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1971c56ac15008bde9caef79e90ace1113be32f
Cr-Commit-Position: refs/heads/master@{#351554}

Powered by Google App Engine
This is Rietveld 408576698