win: Get Crashpad compiling under VS2015

win: Get Crashpad compiling under VS2015

R=mark@chromium.org
BUG=crashpad:1, chromium:440500
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/6082aed2f2978692f0be921bac26608f4afd5aa3

[scottmg, 2015-09-20 18:54:05]

https://codereview.chromium.org/1357833002/diff/20001/client/crashpad_client_...
File client/crashpad_client_win.cc (right):

https://codereview.chromium.org/1357833002/diff/20001/client/crashpad_client_...
client/crashpad_client_win.cc:122:
static_cast<uintptr_t>(response.registration.request_report_event));
It doesn't like widening in a reinterpret.

https://codereview.chromium.org/1357833002/diff/20001/client/settings.cc
File client/settings.cc (left):

https://codereview.chromium.org/1357833002/diff/20001/client/settings.cc#oldc...
client/settings.cc:43: struct ALIGNAS(4) Settings::Data {
VS2015 reports:

d:\src\crashpad\crashpad\client\settings.cc(43): warning C4359:
'crashpad::Settings::Data': Alignment specifier is less than actual alignment
(8), and will be ignored.

I didn't see why it requires the alignment spec (would any compiler ever align a
struct of uint32_t/uint64_t's less than 4 anyway?), but I can add some #ifdefing
if it's necessary to keep it.

https://codereview.chromium.org/1357833002/diff/20001/util/win/exception_hand...
File util/win/exception_handler_server.cc (right):

https://codereview.chromium.org/1357833002/diff/20001/util/win/exception_hand...
util/win/exception_handler_server.cc:355: client_process = OpenProcess(
!

We disabled all the shadowing warnings in Chrome because there were a lot of
false-positives, but this one was a pretty big bug, especially since this path
is almost never executed.

[scottmg, 2015-09-20 19:01:09]

scottmg@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2015-09-21 03:12:58]

LGTM

https://codereview.chromium.org/1357833002/diff/20001/client/settings.cc
File client/settings.cc (right):

https://codereview.chromium.org/1357833002/diff/20001/client/settings.cc#newc...
client/settings.cc:19: #include "base/compiler_specific.h"
Drop this now.

https://codereview.chromium.org/1357833002/diff/20001/util/win/exception_hand...
File util/win/exception_handler_server.cc (right):

https://codereview.chromium.org/1357833002/diff/20001/util/win/exception_hand...
util/win/exception_handler_server.cc:355: client_process = OpenProcess(
Wow.

[scottmg, 2015-09-21 17:51:08]

https://codereview.chromium.org/1357833002/diff/20001/client/settings.cc
File client/settings.cc (right):

https://codereview.chromium.org/1357833002/diff/20001/client/settings.cc#newc...
client/settings.cc:19: #include "base/compiler_specific.h"
On 2015/09/21 03:12:58, Mark Mentovai - August is over wrote:
> Drop this now.

Done.

[scottmg, 2015-09-21 17:51:20]

Committed patchset #3 (id:40001) manually as
6082aed2f2978692f0be921bac26608f4afd5aa3 (presubmit successful).