minidump/minidump_file_writer_test.cc - Issue 1357833002: win: Get Crashpad compiling under VS2015

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_file_writer_test.cc

Issue 1357833002: win: Get Crashpad compiling under VS2015 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: include Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_file_writer_test.cc

diff --git a/minidump/minidump_file_writer_test.cc b/minidump/minidump_file_writer_test.cc

index cc6b1ce57ee7a0e4715286ab5a64ecb85d5bb0ad..147d5c8a0b3c7937e915af8030a0107c5cc41c46 100644

--- a/minidump/minidump_file_writer_test.cc

+++ b/minidump/minidump_file_writer_test.cc

@@ -290,6 +290,7 @@ TEST(MinidumpFileWriter, InitializeFromSnapshot_Exception) {

// but the test should complete without failure.

const uint32_t kSnapshotTime = 0xfd469ab8;

MSVC_SUPPRESS_WARNING(4309); // Truncation of constant value.

+ MSVC_SUPPRESS_WARNING(4838); // Narrowing conversion.

const timeval kSnapshotTimeval = { static_cast<time_t>(kSnapshotTime), 0 };

TestProcessSnapshot process_snapshot;

« no previous file with comments | « compat/win/time.h ('k') | snapshot/win/system_snapshot_win_test.cc » ('j') | no next file with comments »