Issue 1357803002: Oilpan: fix build after r202549.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1357803002: Oilpan: fix build after r202549. (Closed)

Created:
5 years, 3 months ago by sof

Modified:
5 years, 3 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: fix build after r202549. R=haraken BUG=501896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202569

Patch Set 1 #

Patch Set 2 : add explicit LayoutEditor::dispose() #

Patch Set 3 : add missing tracing of m_cssAgent #

Patch Set 4 : add missing tracing of m_cssAgent #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
M	Source/core/inspector/LayoutEditor.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/inspector/LayoutEditor.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/web/InspectorOverlayImpl.cpp	View	1 2 3	3 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

please take a look. Coupling the explicit clearing of LayoutEditor with its immediate destruction is ...

5 years, 3 months ago (2015-09-19 08:59:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357803002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357803002/60001

5 years, 3 months ago (2015-09-19 09:08:48 UTC) #3

commit-bot: I haz the power

5 years, 3 months ago (2015-09-19 11:59:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202569

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages