Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Unified Diff: Source/web/InspectorOverlayImpl.cpp

Issue 1357803002: Oilpan: fix build after r202549. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add missing tracing of m_cssAgent Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/LayoutEditor.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/InspectorOverlayImpl.cpp
diff --git a/Source/web/InspectorOverlayImpl.cpp b/Source/web/InspectorOverlayImpl.cpp
index b028ea6459f1f12f631c39d54c6a4fd632faaa8a..004ada25e379dcf80aba874c628d8eed044a0223 100644
--- a/Source/web/InspectorOverlayImpl.cpp
+++ b/Source/web/InspectorOverlayImpl.cpp
@@ -37,6 +37,7 @@
#include "core/frame/LocalFrame.h"
#include "core/frame/Settings.h"
#include "core/input/EventHandler.h"
+#include "core/inspector/InspectorCSSAgent.h"
#include "core/inspector/InspectorDebuggerAgent.h"
#include "core/inspector/InspectorOverlayHost.h"
#include "core/inspector/LayoutEditor.h"
@@ -202,6 +203,7 @@ DEFINE_TRACE(InspectorOverlayImpl)
visitor->trace(m_overlayHost);
visitor->trace(m_debuggerAgent);
visitor->trace(m_domAgent);
+ visitor->trace(m_cssAgent);
visitor->trace(m_layoutEditor);
visitor->trace(m_hoveredNodeForInspectMode);
}
@@ -611,7 +613,10 @@ void InspectorOverlayImpl::overlayClearSelection(bool commitChanges)
if (commitChanges)
m_layoutEditor->commitChanges();
- m_layoutEditor.clear();
+ if (m_layoutEditor) {
+ m_layoutEditor->dispose();
+ m_layoutEditor.clear();
+ }
if (m_inspectModeHighlightConfig)
highlightNode(m_hoveredNodeForInspectMode.get(), *m_inspectModeHighlightConfig, false);
« no previous file with comments | « Source/core/inspector/LayoutEditor.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698