Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 13578002: Merge 147392 "Simply GIFImageReader error handling" (Closed)

Created:
7 years, 8 months ago by Alpha Left Google
Modified:
7 years, 8 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1453/
Visibility:
Public.

Description

Merge 147392 "Simply GIFImageReader error handling" > Simply GIFImageReader error handling > https://bugs.webkit.org/show_bug.cgi?id=113718 > > Reviewed by Adam Barth. > > When GIFImageReader encounters a parsing error it should just return > without doing any more work. Current code saves a boolean before return, > this is not necessary. > > Tested with existing unit tests. > Tested locally with ASAN build with 60k GIF images. > > * platform/image-decoders/gif/GIFImageDecoder.cpp: > (WebCore::GIFImageDecoder::repetitionCount): > * platform/image-decoders/gif/GIFImageReader.cpp: > (GIFImageReader::decode): > * platform/image-decoders/gif/GIFImageReader.h: > (GIFImageReader::GIFImageReader): > (GIFImageReader): > TBR=hclam@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/image-decoders/gif/GIFImageReader.h View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Alpha Left Google
7 years, 8 months ago (2013-04-03 19:06:34 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698