Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 135773003: Revert of Revert of Add clang-format binaries and scripts for all platforms (Closed)

Created:
6 years, 11 months ago by cmp
Modified:
6 years, 11 months ago
CC:
chromium-reviews, hinoka, awong
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/135773002/ Reason for revert: thakis says he fixed this in a later CL TBR=thakis@chromium.org,ajwong@chromium.org,brettw@chromium.org,phajdan.jr@chromium.org,nick@chromium.org NOTREECHECKS=true NOTRY=true BUG=240309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -0 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/clang_format/README.chromium View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/clang_format/README.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/clang_format/bin/linux/clang-format.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/clang_format/bin/mac/clang-format.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/clang_format/bin/win/clang-format.exe.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/clang_format/scripts/clang-format.el View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/clang_format/scripts/clang-format.py View 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/clang_format/scripts/clang-format-bbedit.applescript View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/clang_format/scripts/clang-format-diff.py View 1 chunk +114 lines, -0 lines 0 comments Download
A third_party/clang_format/scripts/clang-format-sublime.py View 1 chunk +58 lines, -0 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cmp
Created Revert of Revert of Add clang-format binaries and scripts for all platforms
6 years, 11 months ago (2014-01-12 00:16:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmp@chromium.org/135773003/1
6 years, 11 months ago (2014-01-12 00:16:18 UTC) #2
commit-bot: I haz the power
Failed to apply patch for third_party/clang_format/bin/linux/clang-format.sha1: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-12 00:16:23 UTC) #3
cmp
Landed revert manually via drover in https://codereview.chromium.org/135793002.
6 years, 11 months ago (2014-01-12 00:19:45 UTC) #4
ncarter (slow)
6 years, 11 months ago (2014-01-13 19:12:43 UTC) #5
lgtm, I think we can close this

Powered by Google App Engine
This is Rietveld 408576698