Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1357633002: Re-enable test_check_generate_breakpad_symbols_actually_exists. (Closed)

Created:
5 years, 3 months ago by sdefresne
Modified:
5 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Re-enable test_check_generate_breakpad_symbols_actually_exists. Now that http://crrev.com/1315303004/ relanded and the tool is at the correct location, the test can be re-enabled. BUG=522955 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sdefresne
jochen: can you take a look and send to CQ once WebKit is synced with ...
5 years, 3 months ago (2015-09-18 12:26:28 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-18 12:29:28 UTC) #3
sdefresne
On 2015/09/18 at 12:29:28, jochen wrote: > lgtm Thanks. Where can I check if WebKit/Chromium ...
5 years, 3 months ago (2015-09-18 12:30:27 UTC) #4
Stephen White
On 2015/09/18 12:30:27, sdefresne wrote: > On 2015/09/18 at 12:29:28, jochen wrote: > > lgtm ...
5 years, 3 months ago (2015-09-18 13:56:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357633002/1
5 years, 3 months ago (2015-09-18 13:57:06 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 16:17:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202526

Powered by Google App Engine
This is Rietveld 408576698