Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2652)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py

Issue 1357633002: Re-enable test_check_generate_breakpad_symbols_actually_exists. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py b/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py
index 5c61e2f3614f04b67fde4a9eeb0741ecc61af69f..c849c914cc147762ad7b76a51afb7a0db8566e5c 100644
--- a/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py
+++ b/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py
@@ -54,12 +54,10 @@ class TestDumpReaderMultipart(unittest.TestCase):
'--boundary--',
]
-# TODO: Uncomment this test once the generate_breakpad_symbols.py script has been moved; see
-# https://codereview.chromium.org/1351923002.
-# def test_check_generate_breakpad_symbols_actually_exists(self):
-# host = Host()
-# dump_reader = DumpReaderMultipart(host, build_dir=None)
-# self.assertTrue(host.filesystem.exists(dump_reader._path_to_generate_breakpad_symbols()))
+ def test_check_generate_breakpad_symbols_actually_exists(self):
+ host = Host()
+ dump_reader = DumpReaderMultipart(host, build_dir=None)
+ self.assertTrue(host.filesystem.exists(dump_reader._path_to_generate_breakpad_symbols()))
def test_check_is_functional_breakpad_tools_not_found(self):
host = MockHost()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698