Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 135763002: Revert 244210 "Include external touchscreen vid/pid in UMA hardw..." (Closed)

Created:
6 years, 11 months ago by Nico
Modified:
6 years, 11 months ago
Reviewers:
tdresser
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 244210 "Include external touchscreen vid/pid in UMA hardw..." Trying to get the cros asan bot green (crbug.com/333571) > Include external touchscreen vid/pid in UMA hardware profile > > Previously we looked at including the touchscreen name in the UMA > hardware profile: https://codereview.chromium.org/23619085/. > > As that posed a privacy concern, this patch includes the vid/pid > instead. > > BUG=248910 > > Review URL: https://codereview.chromium.org/103893005 TBR=tdresser@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -92 lines) Patch
M trunk/src/chrome/browser/metrics/metrics_log.cc View 4 chunks +0 lines, -18 lines 0 comments Download
M trunk/src/chrome/common/metrics/proto/system_profile.proto View 2 chunks +1 line, -14 lines 0 comments Download
M trunk/src/ui/events/event_utils.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/ui/events/event_utils.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/ui/events/x/touch_factory_x11.h View 5 chunks +0 lines, -14 lines 0 comments Download
M trunk/src/ui/events/x/touch_factory_x11.cc View 4 chunks +0 lines, -39 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
6 years, 11 months ago (2014-01-11 22:52:05 UTC) #1
Nico
6 years, 11 months ago (2014-01-11 22:52:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r244378.

Powered by Google App Engine
This is Rietveld 408576698