Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1988)

Unified Diff: trunk/src/ui/events/x/touch_factory_x11.cc

Issue 135763002: Revert 244210 "Include external touchscreen vid/pid in UMA hardw..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/ui/events/x/touch_factory_x11.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ui/events/x/touch_factory_x11.cc
===================================================================
--- trunk/src/ui/events/x/touch_factory_x11.cc (revision 244377)
+++ trunk/src/ui/events/x/touch_factory_x11.cc (working copy)
@@ -4,7 +4,6 @@
#include "ui/events/x/touch_factory_x11.h"
-#include <X11/Xatom.h>
#include <X11/cursorfont.h>
#include <X11/extensions/XInput.h>
#include <X11/extensions/XInput2.h>
@@ -82,7 +81,6 @@
touch_device_available_ = false;
touch_device_lookup_.reset();
touch_device_list_.clear();
- touchscreen_ids_.clear();
max_touch_points_ = -1;
#if !defined(USE_XI2_MT)
@@ -133,7 +131,6 @@
reinterpret_cast<XITouchClassInfo *>(xiclassinfo);
// Only care direct touch device (such as touch screen) right now
if (tci->mode == XIDirectTouch) {
- CacheTouchscreenIds(display, devinfo->deviceid);
touch_device_lookup_[devinfo->deviceid] = true;
touch_device_list_[devinfo->deviceid] = true;
touch_device_available_ = true;
@@ -271,40 +268,4 @@
}
}
-void TouchFactory::CacheTouchscreenIds(Display* display, int device_id) {
- XDevice* device = XOpenDevice(display, device_id);
- Atom actual_type_return;
- int actual_format_return;
- unsigned long nitems_return;
- unsigned long bytes_after_return;
- unsigned char *prop_return;
-
- const char kDeviceProductIdString[] = "Device Product ID";
- Atom device_product_id_atom =
- XInternAtom(display, kDeviceProductIdString, false);
-
- if (device_product_id_atom != None &&
- XGetDeviceProperty(display, device, device_product_id_atom, 0, 2,
- False, XA_INTEGER, &actual_type_return,
- &actual_format_return, &nitems_return,
- &bytes_after_return, &prop_return) == Success) {
- if (actual_type_return == XA_INTEGER &&
- actual_format_return == 32 &&
- nitems_return == 2) {
- // An actual_format_return of 32 implies that the returned data is an
- // array of longs. See the description of |prop_return| in `man
- // XGetDeviceProperty` for details.
- long* ptr = reinterpret_cast<long*>(prop_return);
-
- // Internal displays will have a vid and pid of 0. Ignore them.
- // ptr[0] is the vid, and ptr[1] is the pid.
- if (ptr[0] || ptr[1])
- touchscreen_ids_.insert(std::make_pair(ptr[0], ptr[1]));
- }
- XFree(prop_return);
- }
-
- XCloseDevice(display, device);
-}
-
} // namespace ui
« no previous file with comments | « trunk/src/ui/events/x/touch_factory_x11.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698