Update web classes to use OVERRIDE / FINAL when needed

Update web classes to use OVERRIDE / FINAL when needed

Update web classes to use OVERRIDE / FINAL when needed. Those are
useful for error checking or performance when the compiler supports it.

Only non-exposed classes were updated to avoid trouble.

R=abarth
BUG=333316
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165421

[eseidel, 2014-01-12 03:42:22]

James or Adam or such should review this.  I don't feel super well versed in the
subtleties of web/

[abarth-chromium, 2014-01-12 04:01:03]

On 2014/01/12 03:42:22, eseidel wrote:
> James or Adam or such should review this.  I don't feel super well versed in
the
> subtleties of web/

There aren't really any subtleties.  We just don't want to use OVERRIDE across
repo boundaries because that makes it harder to change the API.

[Inactive, 2014-01-13 14:35:30]

FYI, this is the last big patch in the series. It looks like I have updated all
the other folders and web/ is the only big one that remains.

[Inactive, 2014-01-17 20:38:35]

On 2014/01/12 04:01:03, abarth wrote:
> On 2014/01/12 03:42:22, eseidel wrote:
> > James or Adam or such should review this.  I don't feel super well versed in
> the
> > subtleties of web/
> 
> There aren't really any subtleties.  We just don't want to use OVERRIDE across
> repo boundaries because that makes it harder to change the API.

This patch does not add any OVERRIDE across repo boundaries AFAICT. Any feedback
on this?

[abarth-chromium, 2014-01-18 08:59:29]

lgtm

[commit-bot: I haz the power, 2014-01-18 08:59:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135753002/1

[commit-bot: I haz the power, 2014-01-18 09:00:20]

Failed to apply patch for Source/web/FrameLoaderClientImpl.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/web/FrameLoaderClientImpl.h
  Hunk #2 FAILED at 55.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/web/FrameLoaderClientImpl.h.rej

Patch:       Source/web/FrameLoaderClientImpl.h
Index: Source/web/FrameLoaderClientImpl.h
diff --git a/Source/web/FrameLoaderClientImpl.h
b/Source/web/FrameLoaderClientImpl.h
index
56b5b286833bddc5db5c787230720848d8aa309d..f2ff8b8ff50a526f72c6ec937562bd80af887416
100644
--- a/Source/web/FrameLoaderClientImpl.h
+++ b/Source/web/FrameLoaderClientImpl.h
@@ -43,10 +43,10 @@ class WebFrameImpl;
 class WebPluginContainerImpl;
 class WebPluginLoadObserver;
 
-class FrameLoaderClientImpl : public WebCore::FrameLoaderClient {
+class FrameLoaderClientImpl FINAL : public WebCore::FrameLoaderClient {
 public:
     FrameLoaderClientImpl(WebFrameImpl* webFrame);
-    ~FrameLoaderClientImpl();
+    virtual ~FrameLoaderClientImpl();
 
     WebFrameImpl* webFrame() const { return m_webFrame; }
 
@@ -55,88 +55,87 @@ public:
     // Notifies the WebView delegate that the JS window object has been
cleared,
     // giving it a chance to bind native objects to the window before script
     // parsing begins.
-    virtual void
dispatchDidClearWindowObjectInWorld(WebCore::DOMWrapperWorld*);
-    virtual void documentElementAvailable();
+    virtual void dispatchDidClearWindowObjectInWorld(WebCore::DOMWrapperWorld*)
OVERRIDE;
+    virtual void documentElementAvailable() OVERRIDE;
 
     // Script in the page tried to allocate too much memory.
     virtual void didExhaustMemoryAvailableForScript();
 
-    virtual void didCreateScriptContext(v8::Handle<v8::Context>, int
extensionGroup, int worldId);
-    virtual void willReleaseScriptContext(v8::Handle<v8::Context>, int
worldId);
+    virtual void didCreateScriptContext(v8::Handle<v8::Context>, int
extensionGroup, int worldId) OVERRIDE;
+    virtual void willReleaseScriptContext(v8::Handle<v8::Context>, int worldId)
OVERRIDE;
 
     // Returns true if we should allow the given V8 extension to be added to
     // the script context at the currently loading page and given extension
group.
-    virtual bool allowScriptExtension(const String& extensionName, int
extensionGroup, int worldId);
-
-    virtual bool hasWebView() const;
-    virtual bool hasFrameView() const;
-    virtual void detachedFromParent();
-    virtual void dispatchWillRequestAfterPreconnect(WebCore::ResourceRequest&);
-    virtual void dispatchWillSendRequest(WebCore::DocumentLoader*, unsigned
long identifier, WebCore::ResourceRequest&, const WebCore::ResourceResponse&
redirectResponse);
-    virtual void dispatchDidReceiveResponse(WebCore::DocumentLoader*, unsigned
long identifier, const WebCore::ResourceResponse&);
-    virtual void dispatchDidChangeResourcePriority(unsigned long identifier,
WebCore::ResourceLoadPriority);
-    virtual void dispatchDidFinishLoading(WebCore::DocumentLoader*, unsigned
long identifier);
-    virtual void dispatchDidLoadResourceFromMemoryCache(const
WebCore::ResourceRequest&, const WebCore::ResourceResponse&);
-    virtual void dispatchDidHandleOnloadEvents();
-    virtual void dispatchDidReceiveServerRedirectForProvisionalLoad();
-    virtual void dispatchDidNavigateWithinPage(WebCore::HistoryItem*,
WebCore::HistoryCommitType);
-    virtual void dispatchWillClose();
-    virtual void dispatchDidStartProvisionalLoad();
-    virtual void dispatchDidReceiveTitle(const String&);
-    virtual void dispatchDidChangeIcons(WebCore::IconType);
-    virtual void dispatchDidCommitLoad(WebCore::Frame*, WebCore::HistoryItem*,
WebCore::HistoryCommitType);
-    virtual void dispatchDidFailProvisionalLoad(const WebCore::ResourceError&);
-    virtual void dispatchDidFailLoad(const WebCore::ResourceError&);
-    virtual void dispatchDidFinishDocumentLoad();
-    virtual void dispatchDidFinishLoad();
+    virtual bool allowScriptExtension(const String& extensionName, int
extensionGroup, int worldId) OVERRIDE;
+
+    virtual bool hasWebView() const OVERRIDE;
+    virtual void detachedFromParent() OVERRIDE;
+    virtual void dispatchWillRequestAfterPreconnect(WebCore::ResourceRequest&)
OVERRIDE;
+    virtual void dispatchWillSendRequest(WebCore::DocumentLoader*, unsigned
long identifier, WebCore::ResourceRequest&, const WebCore::ResourceResponse&
redirectResponse) OVERRIDE;
+    virtual void dispatchDidReceiveResponse(WebCore::DocumentLoader*, unsigned
long identifier, const WebCore::ResourceResponse&) OVERRIDE;
+    virtual void dispatchDidChangeResourcePriority(unsigned long identifier,
WebCore::ResourceLoadPriority) OVERRIDE;
+    virtual void dispatchDidFinishLoading(WebCore::DocumentLoader*, unsigned
long identifier) OVERRIDE;
+    virtual void dispatchDidLoadResourceFromMemoryCache(const
WebCore::ResourceRequest&, const WebCore::ResourceResponse&) OVERRIDE;
+    virtual void dispatchDidHandleOnloadEvents() OVERRIDE;
+    virtual void dispatchDidReceiveServerRedirectForProvisionalLoad() OVERRIDE;
+    virtual void dispatchDidNavigateWithinPage(WebCore::HistoryItem*,
WebCore::HistoryCommitType) OVERRIDE;
+    virtual void dispatchWillClose() OVERRIDE;
+    virtual void dispatchDidStartProvisionalLoad() OVERRIDE;
+    virtual void dispatchDidReceiveTitle(const String&) OVERRIDE;
+    virtual void dispatchDidChangeIcons(WebCore::IconType) OVERRIDE;
+    virtual void dispatchDidCommitLoad(WebCore::Frame*, WebCore::HistoryItem*,
WebCore::HistoryCommitType) OVERRIDE;
+    virtual void dispatchDidFailProvisionalLoad(const WebCore::ResourceError&)
OVERRIDE;
+    virtual void dispatchDidFailLoad(const WebCore::ResourceError&) OVERRIDE;
+    virtual void dispatchDidFinishDocumentLoad() OVERRIDE;
+    virtual void dispatchDidFinishLoad() OVERRIDE;
     virtual void dispatchDidFirstVisuallyNonEmptyLayout() OVERRIDE;
-    virtual WebCore::NavigationPolicy decidePolicyForNavigation(const
WebCore::ResourceRequest&, WebCore::DocumentLoader*, WebCore::NavigationPolicy);
-    virtual void dispatchWillRequestResource(WebCore::FetchRequest*);
-    virtual void dispatchWillSendSubmitEvent(PassRefPtr<WebCore::FormState>);
-    virtual void dispatchWillSubmitForm(PassRefPtr<WebCore::FormState>);
-    virtual void postProgressStartedNotification(WebCore::LoadStartType);
-    virtual void postProgressEstimateChangedNotification();
-    virtual void postProgressFinishedNotification();
-    virtual void loadURLExternally(const WebCore::ResourceRequest&,
WebCore::NavigationPolicy, const String& suggestedName = String());
-    virtual bool navigateBackForward(int offset) const;
-    virtual void didAccessInitialDocument();
-    virtual void didDisownOpener();
-    virtual void didDisplayInsecureContent();
-    virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const
WebCore::KURL& insecureURL);
-    virtual void didDetectXSS(const WebCore::KURL&, bool didBlockEntirePage);
-    virtual void didDispatchPingLoader(const WebCore::KURL&);
-    virtual void selectorMatchChanged(const Vector<String>& addedSelectors,
const Vector<String>& removedSelectors);
+    virtual WebCore::NavigationPolicy decidePolicyForNavigation(const
WebCore::ResourceRequest&, WebCore::DocumentLoader*, WebCore::NavigationPolicy)
OVERRIDE;
+    virtual void dispatchWillRequestResource(WebCore::FetchRequest*) OVERRIDE;
+    virtual void dispatchWillSendSubmitEvent(PassRefPtr<WebCore::FormState>)
OVERRIDE;
+    virtual void dispatchWillSubmitForm(PassRefPtr<WebCore::FormState>)
OVERRIDE;
+    virtual void postProgressStartedNotification(WebCore::LoadStartType)
OVERRIDE;
+    virtual void postProgressEstimateChangedNotification() OVERRIDE;
+    virtual void postProgressFinishedNotification() OVERRIDE;
+    virtual void loadURLExternally(const WebCore::ResourceRequest&,
WebCore::NavigationPolicy, const String& suggestedName = String()) OVERRIDE;
+    virtual bool navigateBackForward(int offset) const OVERRIDE;
+    virtual void didAccessInitialDocument() OVERRIDE;
+    virtual void didDisownOpener() OVERRIDE;
+    virtual void didDisplayInsecureContent() OVERRIDE;
+    virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const
WebCore::KURL& insecureURL) OVERRIDE;
+    virtual void didDetectXSS(const WebCore::KURL&, bool didBlockEntirePage)
OVERRIDE;
+    virtual void didDispatchPingLoader(const WebCore::KURL&) OVERRIDE;
+    virtual void selectorMatchChanged(const Vector<String>& addedSelectors,
const Vector<String>& removedSelectors) OVERRIDE;
     virtual PassRefPtr<WebCore::DocumentLoader> createDocumentLoader(
-        const WebCore::ResourceRequest&, const WebCore::SubstituteData&);
-    virtual WTF::String userAgent(const WebCore::KURL&);
-    virtual WTF::String doNotTrackValue();
-    virtual void transitionToCommittedForNewPage();
-    virtual PassRefPtr<WebCore::Frame> createFrame(const WebCore::KURL&, const
WTF::AtomicString& name, const WTF::String& referrer,
WebCore::HTMLFrameOwnerElement*);
+        const WebCore::ResourceRequest&, const WebCore::SubstituteData&)
OVERRIDE;
+    virtual WTF::String userAgent(const WebCore::KURL&) OVERRIDE;
+    virtual WTF::String doNotTrackValue() OVERRIDE;
+    virtual void transitionToCommittedForNewPage() OVERRIDE;
+    virtual PassRefPtr<WebCore::Frame> createFrame(const WebCore::KURL&, const
WTF::AtomicString& name, const WTF::String& referrer,
WebCore::HTMLFrameOwnerElement*) OVERRIDE;
     virtual PassRefPtr<WebCore::Widget> createPlugin(
         const WebCore::IntSize&, WebCore::HTMLPlugInElement*, const
WebCore::KURL&,
         const Vector<WTF::String>&, const Vector<WTF::String>&,
-        const WTF::String&, bool loadManually);
+        const WTF::String&, bool loadManually) OVERRIDE;
     virtual PassRefPtr<WebCore::Widget> createJavaAppletWidget(
         const WebCore::IntSize&,
         WebCore::HTMLAppletElement*,
         const WebCore::KURL& /* base_url */,
         con…
(message too large)

[commit-bot: I haz the power, 2014-01-18 15:10:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135753002/680001

[commit-bot: I haz the power, 2014-01-18 15:43:44]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-18 16:27:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135753002/680001

[commit-bot: I haz the power, 2014-01-18 16:51:51]

Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-18 18:26:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135753002/680001

[commit-bot: I haz the power, 2014-01-18 18:52:25]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-19 03:41:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135753002/680001

[commit-bot: I haz the power, 2014-01-19 04:10:55]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-20 15:00:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135753002/680001

[commit-bot: I haz the power, 2014-01-20 15:00:43]

Failed to apply patch for Source/web/WebSharedWorkerImpl.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/web/WebSharedWorkerImpl.h
  Hunk #2 FAILED at 69.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/web/WebSharedWorkerImpl.h.rej

Patch:       Source/web/WebSharedWorkerImpl.h
Index: Source/web/WebSharedWorkerImpl.h
diff --git a/Source/web/WebSharedWorkerImpl.h b/Source/web/WebSharedWorkerImpl.h
index
2e8c268f22c24af217b49d81572eadb6ce466f20..5c85c7759a188d8937d240ac832ff408fda5f175
100644
--- a/Source/web/WebSharedWorkerImpl.h
+++ b/Source/web/WebSharedWorkerImpl.h
@@ -59,7 +59,7 @@ class WebSharedWorkerClient;
 // It can't use it directly since it uses WebKit types, so this class converts
the data types.
 // When the WebCore::SharedWorker object wants to call
WebCore::WorkerReportingProxy, this class will
 // convert to Chrome data types first and then call the supplied
WebCommonWorkerClient.
-class WebSharedWorkerImpl
+class WebSharedWorkerImpl FINAL
     : public WebCore::WorkerReportingProxy
     , public WebCore::WorkerLoaderProxy
     , public WebFrameClient
@@ -69,36 +69,36 @@ public:
 
     // WebCore::WorkerReportingProxy methods:
     virtual void reportException(
-        const WTF::String&, int, int, const WTF::String&);
+        const WTF::String&, int, int, const WTF::String&) OVERRIDE;
     virtual void reportConsoleMessage(
         WebCore::MessageSource, WebCore::MessageLevel,
-        const WTF::String&, int, const WTF::String&);
-    virtual void postMessageToPageInspector(const WTF::String&);
-    virtual void updateInspectorStateCookie(const WTF::String&);
-    virtual void workerGlobalScopeStarted();
-    virtual void workerGlobalScopeClosed();
-    virtual void workerGlobalScopeDestroyed();
+        const WTF::String&, int, const WTF::String&) OVERRIDE;
+    virtual void postMessageToPageInspector(const WTF::String&) OVERRIDE;
+    virtual void updateInspectorStateCookie(const WTF::String&) OVERRIDE;
+    virtual void workerGlobalScopeStarted() OVERRIDE;
+    virtual void workerGlobalScopeClosed() OVERRIDE;
+    virtual void workerGlobalScopeDestroyed() OVERRIDE;
 
     // WebCore::WorkerLoaderProxy methods:
-    virtual void postTaskToLoader(PassOwnPtr<WebCore::ExecutionContextTask>);
+    virtual void postTaskToLoader(PassOwnPtr<WebCore::ExecutionContextTask>)
OVERRIDE;
     virtual bool postTaskForModeToWorkerGlobalScope(
-        PassOwnPtr<WebCore::ExecutionContextTask>, const WTF::String& mode);
+        PassOwnPtr<WebCore::ExecutionContextTask>, const WTF::String& mode)
OVERRIDE;
 
     // WebFrameClient methods to support resource loading thru the 'shadow
page'.
-    virtual WebApplicationCacheHost* createApplicationCacheHost(WebFrame*,
WebApplicationCacheHostClient*);
+    virtual WebApplicationCacheHost* createApplicationCacheHost(WebFrame*,
WebApplicationCacheHostClient*) OVERRIDE;
 
     // WebSharedWorker methods:
-    virtual void startWorkerContext(const WebURL&, const WebString& name, const
WebString& userAgent, const WebString& sourceCode, const WebString&
contentSecurityPolicy, WebContentSecurityPolicyType, long long cacheId);
-    virtual void connect(WebMessagePortChannel*);
-    virtual void terminateWorkerContext();
-    virtual void clientDestroyed();
-
-    virtual void pauseWorkerContextOnStart();
-    virtual void resumeWorkerContext();
-    virtual void attachDevTools();
-    virtual void reattachDevTools(const WebString& savedState);
-    virtual void detachDevTools();
-    virtual void dispatchDevToolsMessage(const WebString&);
+    virtual void startWorkerContext(const WebURL&, const WebString& name, const
WebString& userAgent, const WebString& sourceCode, const WebString&
contentSecurityPolicy, WebContentSecurityPolicyType, long long cacheId)
OVERRIDE;
+    virtual void connect(WebMessagePortChannel*) OVERRIDE;
+    virtual void terminateWorkerContext() OVERRIDE;
+    virtual void clientDestroyed() OVERRIDE;
+
+    virtual void pauseWorkerContextOnStart() OVERRIDE;
+    virtual void resumeWorkerContext() OVERRIDE;
+    virtual void attachDevTools() OVERRIDE;
+    virtual void reattachDevTools(const WebString& savedState) OVERRIDE;
+    virtual void detachDevTools() OVERRIDE;
+    virtual void dispatchDevToolsMessage(const WebString&) OVERRIDE;
 
 private:
     virtual ~WebSharedWorkerImpl();

[commit-bot: I haz the power, 2014-01-20 18:13:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135753002/1040001

[commit-bot: I haz the power, 2014-01-20 19:09:43]

Retried try job too often on win_blink_rel for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2014-01-20 19:11:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135753002/1040001

[commit-bot: I haz the power, 2014-01-20 20:16:23]

Change committed as 165421