Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: Source/web/WebDataSourceImpl.h

Issue 135753002: Update web classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/ValidationMessageClientImpl.h ('k') | Source/web/WebDevToolsAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebDataSourceImpl.h
diff --git a/Source/web/WebDataSourceImpl.h b/Source/web/WebDataSourceImpl.h
index e6db579b103e0926fd349131ee2d95e180199710..0949caee9b185981b60a7d39f897492e5ea0d629 100644
--- a/Source/web/WebDataSourceImpl.h
+++ b/Source/web/WebDataSourceImpl.h
@@ -45,7 +45,7 @@ namespace blink {
class WebPluginLoadObserver;
-class WebDataSourceImpl : public WebCore::DocumentLoader, public WebDataSource {
+class WebDataSourceImpl FINAL : public WebCore::DocumentLoader, public WebDataSource {
public:
static PassRefPtr<WebDataSourceImpl> create(WebCore::Frame*, const WebCore::ResourceRequest&, const WebCore::SubstituteData&);
@@ -55,21 +55,21 @@ public:
}
// WebDataSource methods:
- virtual const WebURLRequest& originalRequest() const;
- virtual const WebURLRequest& request() const;
- virtual const WebURLResponse& response() const;
- virtual bool hasUnreachableURL() const;
- virtual WebURL unreachableURL() const;
- virtual void appendRedirect(const WebURL&);
- virtual void redirectChain(WebVector<WebURL>&) const;
- virtual bool isClientRedirect() const;
- virtual bool replacesCurrentHistoryItem() const;
- virtual WebNavigationType navigationType() const;
- virtual double triggeringEventTime() const;
- virtual ExtraData* extraData() const;
- virtual void setExtraData(ExtraData*);
- virtual WebApplicationCacheHost* applicationCacheHost();
- virtual void setNavigationStartTime(double);
+ virtual const WebURLRequest& originalRequest() const OVERRIDE;
+ virtual const WebURLRequest& request() const OVERRIDE;
+ virtual const WebURLResponse& response() const OVERRIDE;
+ virtual bool hasUnreachableURL() const OVERRIDE;
+ virtual WebURL unreachableURL() const OVERRIDE;
+ virtual void appendRedirect(const WebURL&) OVERRIDE;
+ virtual void redirectChain(WebVector<WebURL>&) const OVERRIDE;
+ virtual bool isClientRedirect() const OVERRIDE;
+ virtual bool replacesCurrentHistoryItem() const OVERRIDE;
+ virtual WebNavigationType navigationType() const OVERRIDE;
+ virtual double triggeringEventTime() const OVERRIDE;
+ virtual ExtraData* extraData() const OVERRIDE;
+ virtual void setExtraData(ExtraData*) OVERRIDE;
+ virtual WebApplicationCacheHost* applicationCacheHost() OVERRIDE;
+ virtual void setNavigationStartTime(double) OVERRIDE;
static WebNavigationType toWebNavigationType(WebCore::NavigationType type);
@@ -78,7 +78,7 @@ public:
private:
WebDataSourceImpl(WebCore::Frame*, const WebCore::ResourceRequest&, const WebCore::SubstituteData&);
- ~WebDataSourceImpl();
+ virtual ~WebDataSourceImpl();
// Mutable because the const getters will magically sync these to the
// latest version from WebKit.
« no previous file with comments | « Source/web/ValidationMessageClientImpl.h ('k') | Source/web/WebDevToolsAgentImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698