Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: media/blink/skcanvas_video_renderer.cc

Issue 1357423009: gfx: Make conversions from Size to SizeF be explicit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/skcanvas_video_renderer.cc
diff --git a/media/blink/skcanvas_video_renderer.cc b/media/blink/skcanvas_video_renderer.cc
index 3b64e38f81b30159eef8dc2d0fb4799ae29410f2..546ab8a358e636ff8ad79131ec0ede9546870e63 100644
--- a/media/blink/skcanvas_video_renderer.cc
+++ b/media/blink/skcanvas_video_renderer.cc
@@ -352,7 +352,7 @@ void SkCanvasVideoRenderer::Paint(const scoped_refptr<VideoFrame>& video_frame,
const bool need_transform =
video_rotation != VIDEO_ROTATION_0 ||
- dest_rect.size() != video_frame->visible_rect().size() ||
+ dest_rect.size() != gfx::SizeF(video_frame->visible_rect().size()) ||
no sievers 2015/09/24 00:07:33 hmm, do we really want to compare the rounded inte
danakj 2015/09/24 00:36:05 Ya I'm not sure, but this is what the code does to
DaleCurtis 2015/09/24 01:40:09 It seems like .size() should be dropped from both
danakj 2015/09/24 17:48:35 I'd like to not change behaviour in this patch, bu
!dest_rect.origin().IsOrigin();
if (need_transform) {
canvas->save();

Powered by Google App Engine
This is Rietveld 408576698