gfx: Make conversions from Size to SizeF be explicit.

media/blink/skcanvas_video_renderer.cc

   // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/skcanvas_video_renderer.h"
 
 #include "gpu/GLES2/gl2extchromium.h"
 #include "gpu/command_buffer/client/gles2_interface.h"
 #include "gpu/command_buffer/common/mailbox_holder.h"
 #include "media/base/video_frame.h"
@@ skipping 334 matching lines @@
       return;
     last_timestamp_ = video_frame->timestamp();
   }
   last_image_deleting_timer_.Reset();
 
   paint.setXfermodeMode(mode);
   paint.setFilterQuality(kLow_SkFilterQuality);
 
   const bool need_transform =
       video_rotation != VIDEO_ROTATION_0 ||
-      dest_rect.size() != video_frame->visible_rect().size() ||
+      dest_rect.size() != gfx::SizeF(video_frame->visible_rect().size()) ||

[no sievers, 2015/09/24 00:07:33]

hmm, do we really want to compare the rounded integer sizes here instead?

[danakj, 2015/09/24 00:36:05]

Ya I'm not sure, but this is what the code does today. Pointing out potential
wierdness is why I wanted to land this. I was going to +dalecurtis for media
afterward, but can do that now. :)

[DaleCurtis, 2015/09/24 01:40:09]

It seems like .size() should be dropped from both sides? I'd guess that's what
the original intention was here. I.e. use the implicit == which will compare the
integer width an height.

[danakj, 2015/09/24 17:48:35]

I'd like to not change behaviour in this patch, but we can do that in a
followup. That ok?

       !dest_rect.origin().IsOrigin();
   if (need_transform) {
     canvas->save();
     canvas->translate(
         SkFloatToScalar(dest_rect.x() + (dest_rect.width() * 0.5f)),
         SkFloatToScalar(dest_rect.y() + (dest_rect.height() * 0.5f)));
     SkScalar angle = SkFloatToScalar(0.0f);
     switch (video_rotation) {
       case VIDEO_ROTATION_0:
         break;
@@ skipping 215 matching lines @@
   video_frame->UpdateReleaseSyncPoint(&client);
 }
 
 void SkCanvasVideoRenderer::ResetCache() {
   // Clear cached values.
   last_image_ = nullptr;
   last_timestamp_ = kNoTimestamp();
 }
 
 }  // namespace media