Chromium Code Reviews| Index: build/config/compiler/BUILD.gn |
| diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn |
| index cc95d62fee6ad76d2799a67e837c52ed3f262916..81e998dd2a11d42c4b2b4b8a0add9a9fb81a0c70 100644 |
| --- a/build/config/compiler/BUILD.gn |
| +++ b/build/config/compiler/BUILD.gn |
| @@ -11,7 +11,7 @@ if (cpu_arch == "arm") { |
| # compiler --------------------------------------------------------------------- |
| # |
| # Base compiler configuration. |
| -# |
| +# |
| # See also "runtime_library" below for related stuff and a discusison about |
| # where stuff should go. Put warning related stuff in the "warnings" config. |
| @@ -469,7 +469,7 @@ config("no_rtti") { |
| # Warnings --------------------------------------------------------------------- |
| # |
| # This is where we disable various warnings that we've decided aren't |
| -# worthwhile. |
| +# worthwhile, and enable special warnings. |
| config("default_warnings") { |
| if (is_win) { |
| @@ -580,6 +580,20 @@ config("default_warnings") { |
| } |
| } |
| +# This will generate warnings when using Clang if code generates exit-time |
| +# destructors, which will slow down closing the program." |
|
brettw
2014/01/15 05:00:16
Extra "
bbudge
2014/01/15 13:16:49
Done.
|
| +# TODO(thakis): Make this a blacklist instead, http://crbug.com/101600 |
| +config("wexit_time_destructors") { |
| + if (is_clang) { |
| + cflags = [ "-Wexit-time-destructors" ] |
| + #'xcode_settings': { |
|
brettw
2014/01/15 05:00:16
You don't need this.
bbudge
2014/01/15 13:16:49
Done.
|
| + # 'WARNING_CFLAGS': [ |
| + # '-Wexit-time-destructors', |
| + # ], |
| + #}, |
| + } |
| +} |
| + |
| # Optimization ----------------------------------------------------------------- |
| config("optimize") { |
| @@ -641,3 +655,4 @@ config("no_symbols") { |
| cflags = [ "-g0" ] |
| } |
| } |
| + |