Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1357243003: Content description for settings button in keyboard accessory. (Closed)

Created:
5 years, 3 months ago by please use gerrit instead
Modified:
5 years, 3 months ago
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, hwi, jdonnelly+autofillwatch_chromium.org, rouslan+autofill_chromium.org, zkoch1, Ilya Sherman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Content description for settings button in keyboard accessory. A screen reader should verbalise "settings" instead of "autofill settings three dots" when the user taps the gear icon on the keyboard accessory. BUG=428087 Committed: https://crrev.com/7647c0a5f887011a4976a936326a46b956623e61 Cr-Commit-Position: refs/heads/master@{#350040}

Patch Set 1 #

Patch Set 2 : Fix iOS. #

Total comments: 4

Patch Set 3 : Lower case 'settings', add comment, elaborate description for translators. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M build/ios/grit_whitelist.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M components/autofill_strings.grdp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
please use gerrit instead
Ilya, PTAL.
5 years, 3 months ago (2015-09-21 16:34:43 UTC) #2
Evan Stade
https://codereview.chromium.org/1357243003/diff/20001/components/autofill/core/browser/autofill_external_delegate.cc File components/autofill/core/browser/autofill_external_delegate.cc (right): https://codereview.chromium.org/1357243003/diff/20001/components/autofill/core/browser/autofill_external_delegate.cc#newcode297 components/autofill/core/browser/autofill_external_delegate.cc:297: IsKeyboardAccessoryEnabled() ? IDS_AUTOFILL_OPTIONS_CONTENT_DESCRIPTION this seems like another place we ...
5 years, 3 months ago (2015-09-21 20:03:47 UTC) #4
please use gerrit instead
Evan, PTAL Patch 2. https://codereview.chromium.org/1357243003/diff/20001/components/autofill/core/browser/autofill_external_delegate.cc File components/autofill/core/browser/autofill_external_delegate.cc (right): https://codereview.chromium.org/1357243003/diff/20001/components/autofill/core/browser/autofill_external_delegate.cc#newcode297 components/autofill/core/browser/autofill_external_delegate.cc:297: IsKeyboardAccessoryEnabled() ? IDS_AUTOFILL_OPTIONS_CONTENT_DESCRIPTION Added a ...
5 years, 3 months ago (2015-09-21 20:34:44 UTC) #6
please use gerrit instead
On 2015/09/21 at 20:34:44, Rouslan wrote: > Evan, PTAL Patch 2. s/2/3
5 years, 3 months ago (2015-09-21 20:35:10 UTC) #7
Evan Stade
lgtm
5 years, 3 months ago (2015-09-21 21:13:03 UTC) #8
Ilya Sherman
lgtm
5 years, 3 months ago (2015-09-21 21:34:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357243003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357243003/40001
5 years, 3 months ago (2015-09-21 21:45:44 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-21 22:12:18 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 22:12:52 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7647c0a5f887011a4976a936326a46b956623e61
Cr-Commit-Position: refs/heads/master@{#350040}

Powered by Google App Engine
This is Rietveld 408576698