components/autofill/core/browser/autofill_external_delegate.cc - Issue 1357243003: Content description for settings button in keyboard accessory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate.cc

Issue 1357243003: Content description for settings button in keyboard accessory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Lower case 'settings', add comment, elaborate description for translators. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/browser/autofill_external_delegate.cc

diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc

index 82b7396c7c8f999ac184d9885014910a9f031e49..c9471f4ccb99e6831eb16d743f454e96767ad42b 100644

--- a/components/autofill/core/browser/autofill_external_delegate.cc

+++ b/components/autofill/core/browser/autofill_external_delegate.cc

@@ -293,8 +293,11 @@ void AutofillExternalDelegate::ApplyAutofillOptions(

}

// Append the 'Chrome Autofill options' menu item;

- suggestions->push_back(Suggestion(

- l10n_util::GetStringUTF16(IDS_AUTOFILL_OPTIONS_POPUP)));

+ // TODO(rouslan): Switch on the platform in the GRD file when keyboard

+ // accessory becomes default on Android.

+ suggestions->push_back(Suggestion(l10n_util::GetStringUTF16(

+ IsKeyboardAccessoryEnabled() ? IDS_AUTOFILL_OPTIONS_CONTENT_DESCRIPTION

+ : IDS_AUTOFILL_OPTIONS_POPUP)));

suggestions->back().frontend_id = POPUP_ITEM_ID_AUTOFILL_OPTIONS;

if (IsKeyboardAccessoryEnabled())

suggestions->back().icon = base::ASCIIToUTF16("settings");

« no previous file with comments | « build/ios/grit_whitelist.txt ('k') | components/autofill_strings.grdp » ('j') | no next file with comments »