Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: content/browser/frame_host/navigator.h

Issue 135723003: Move DidCommitProvisionalLoad code from RenderView to RenderFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Some clean up, ready to start reviewing. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator.h
diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h
index d069bf8a4e915a377f30fcdc619ec01be0232138..bf85d0b4ac5c5f2decb58d9a267b8f3922aef915 100644
--- a/content/browser/frame_host/navigator.h
+++ b/content/browser/frame_host/navigator.h
@@ -11,6 +11,7 @@
class GURL;
struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;
+struct FrameHostMsg_DidCommitProvisionalLoad_Params;
Charlie Reis 2014/02/05 23:30:37 nit: Alphabetize
nasko 2014/02/06 01:55:13 Done.
namespace base {
class TimeTicks;
@@ -55,6 +56,11 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
const GURL& source_url,
const GURL& target_url) {}
+ // The RenderFrameHostImpl has navigated.
Charlie Reis 2014/02/05 23:30:37 Let's say "has committed a navigation."
nasko 2014/02/06 01:55:13 Done.
+ virtual void DidNavigate(
+ RenderFrameHostImpl* render_frame_host,
+ const FrameHostMsg_DidCommitProvisionalLoad_Params& params) {}
+
// Causes the Navigator to navigate in the right render frame to |entry|,
// which must be already part of the entries in the navigation controller.
// This does not change the NavigationController state.

Powered by Google App Engine
This is Rietveld 408576698