Move DidCommitProvisionalLoad code from RenderView to RenderFrame.

content/browser/frame_host/navigator_delegate.h

Index: content/browser/frame_host/navigator_delegate.h
diff --git a/content/browser/frame_host/navigator_delegate.h b/content/browser/frame_host/navigator_delegate.h
index e91827769f30f4925e14e39bda67c35cd2962934..973b6f7a8c241d5265208dfa636241a6eb57119c 100644
--- a/content/browser/frame_host/navigator_delegate.h
+++ b/content/browser/frame_host/navigator_delegate.h
@@ -5,16 +5,23 @@
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_DELEGATE_H_
 
+#include "base/strings/string16.h"
 #include "content/public/browser/invalidate_type.h"
 #include "content/public/browser/navigation_controller.h"
+#include "content/public/common/page_transition_types.h"
+
+class GURL;
+struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;
+struct FrameHostMsg_DidCommitProvisionalLoad_Params;

[Charlie Reis, 2014/02/05 23:30:37]

nit: Alphabetize

[nasko, 2014/02/06 01:55:13]

Done.

 
 namespace content {
 
-class RenderFrameHost;
+class RenderFrameHostImpl;
+struct LoadCommittedDetails;
 
 // A delegate API used by Navigator to notify its embedder of navigation
 // related events.
-class NavigatorDelegate {
+class CONTENT_EXPORT NavigatorDelegate {
  public:
   // The RenderFrameHost started a provisional load for the frame
   // represented by |render_frame_host|.
@@ -37,6 +44,30 @@ class NavigatorDelegate {
       RenderFrameHostImpl* render_frame_host,
       const GURL& validated_target_url) {}
 
+  // A commit was processed in |render_frame_host|.

[Charlie Reis, 2014/02/05 23:30:37]

A navigation was committed in...

[nasko, 2014/02/06 01:55:13]

Done.

+  virtual void DidCommitProvisionalLoad(
+      int64 frame_id,
+      const base::string16& frame_unique_name,
+      bool is_main_frame,
+      const GURL& url,
+      PageTransition transition_type,
+      RenderFrameHostImpl* render_frame_host) {}
+
+  // Handles post-navigation tasks in navigation AFTER the entry has been
+  // committed to the navigation controller. Note that the navigation entry is

[Charlie Reis, 2014/02/05 23:30:37]

nit: NavigationController, NavigationEntry

[nasko, 2014/02/06 01:55:13]

Done.

+  // not provided since it may be invalid/changed after being committed. The
+  // current navigation entry is in the NavigationController at this point.

[Charlie Reis, 2014/02/05 23:30:37]

What do you mean by "current" and "in the NavigationController?"  Maybe we
should say that the NavigationController's last committed entry is for this
navigation?

[nasko, 2014/02/06 01:55:13]

This is a comment that was just moved from WebContentsImpl.h, but I agree that
last committed entry makes more sense.

+  virtual void DidNavigateMainFramePostCommit(
+      const LoadCommittedDetails& details,
+      const FrameHostMsg_DidCommitProvisionalLoad_Params& params) {}
+  virtual void DidNavigateAnyFramePostCommit(
+      RenderFrameHostImpl* render_frame_host,
+      const LoadCommittedDetails& details,
+      const FrameHostMsg_DidCommitProvisionalLoad_Params& params) {}
+
+  virtual void SetMainFrameMimeType(const std::string& mime_type) {}
+  virtual bool CanOverscrollContent();
+
   // Notification to the Navigator embedder that navigation state has
   // changed. This method corresponds to
   // WebContents::NotifyNavigationStateChanged.