Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: sync/tools/invalidation_helper.cc

Issue 1357143002: Revert of Merge duplicate code in invalidation helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/tools/invalidation_helper.h ('k') | sync/tools/sync_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/tools/invalidation_helper.cc
diff --git a/sync/tools/invalidation_helper.cc b/sync/tools/invalidation_helper.cc
new file mode 100644
index 0000000000000000000000000000000000000000..61a4b87f71f2a71a8e0dc4e1ba92b7c200472b34
--- /dev/null
+++ b/sync/tools/invalidation_helper.cc
@@ -0,0 +1,35 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "sync/tools/invalidation_helper.h"
+
+#include "google/cacheinvalidation/types.pb.h"
+
+namespace syncer {
+
+bool RealModelTypeToObjectId(ModelType model_type,
+ invalidation::ObjectId* object_id) {
+ std::string notification_type;
+ if (!RealModelTypeToNotificationType(model_type, &notification_type)) {
+ return false;
+ }
+ object_id->Init(ipc::invalidation::ObjectSource::CHROME_SYNC,
+ notification_type);
+ return true;
+}
+
+ObjectIdSet ModelTypeSetToObjectIdSet(ModelTypeSet model_types) {
+ ObjectIdSet ids;
+ for (ModelTypeSet::Iterator it = model_types.First(); it.Good(); it.Inc()) {
+ invalidation::ObjectId model_type_as_id;
+ if (!RealModelTypeToObjectId(it.Get(), &model_type_as_id)) {
+ DLOG(WARNING) << "Invalid model type " << it.Get();
+ continue;
+ }
+ ids.insert(model_type_as_id);
+ }
+ return ids;
+}
+
+} // namespace syncer
« no previous file with comments | « sync/tools/invalidation_helper.h ('k') | sync/tools/sync_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698