Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1357143002: Revert of Merge duplicate code in invalidation helper. (Closed)

Created:
5 years, 3 months ago by Peter Kasting
Modified:
5 years, 3 months ago
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org, Abhishek
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Merge duplicate code in invalidation helper. (patchset #2 id:40001 of https://codereview.chromium.org/1310323009/ ) Reason for revert: Broke gn gen; see e.g. http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/56707/steps/generate_build_files/logs/stdio Original issue's description: > Merge duplicate code in invalidation helper. > > There is code duplication in: > components/sync_driver/invalidation_helper > sync/tools/invalidation_helper > > This patch merged those files by removing duplicate code in > sync/tools/invalidation_helper. > > BUG=528259 > > Committed: https://crrev.com/de7123741b492a12f35a0cbd7b3e36ff3839a3e6 > Cr-Commit-Position: refs/heads/master@{#349849} TBR=droger@chromium.org,zea@chromium.org,jitendra.ks@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=528259 Committed: https://crrev.com/506d23f8515077d82f8621b143b6870ce6b55342 Cr-Commit-Position: refs/heads/master@{#349858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -5 lines) Patch
M sync/tools/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M sync/tools/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A sync/tools/invalidation_helper.h View 1 chunk +21 lines, -0 lines 0 comments Download
A sync/tools/invalidation_helper.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M sync/tools/sync_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M sync/tools/sync_listen_notifications.cc View 2 chunks +1 line, -1 line 0 comments Download
M sync/tools/sync_tools.gyp View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Peter Kasting
Created Revert of Merge duplicate code in invalidation helper.
5 years, 3 months ago (2015-09-19 07:13:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357143002/1
5 years, 3 months ago (2015-09-19 07:13:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-19 07:14:17 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/506d23f8515077d82f8621b143b6870ce6b55342 Cr-Commit-Position: refs/heads/master@{#349858}
5 years, 3 months ago (2015-09-19 07:15:03 UTC) #4
droger
pkasting: Thanks. Do you know by any chance why the CL passed the CQ? Is ...
5 years, 3 months ago (2015-09-21 07:42:38 UTC) #5
Peter Kasting
5 years, 3 months ago (2015-09-21 18:21:31 UTC) #6
Message was sent while issue was closed.
On 2015/09/21 07:42:38, droger wrote:
> pkasting: Thanks. Do you know by any chance why the CL passed the CQ? Is there
a
> try bot that we could run to repro the failure?

I do not know, sorry.

Powered by Google App Engine
This is Rietveld 408576698