Issue 135703003: Merge 245212 "Added UMA metrics for ChromeOS first-run UI."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 135703003: Merge 245212 "Added UMA metrics for ChromeOS first-run UI." (Closed)

Created:
6 years, 11 months ago by dzhioev (left Google)

Modified:
6 years, 11 months ago

Reviewers:
dzhioev (left Google)

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, Ilya Sherman, asvitkine+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, jar (doing other things)

Base URL:
svn://svn.chromium.org/chrome/branches/1750/src

Visibility:
Public.

More Reviews

Description

Merge 245212 "Added UMA metrics for ChromeOS first-run UI." > Added UMA metrics for ChromeOS first-run UI. > > Added following metrics: > * CrosFirstRun.DialogShown > * CrosFirstRun.FurthestStep > * CrosFirstRun.TimeSpent > * CrosFirstRun.TimeSpentOnStepAppList > * CrosFirstRun.TimeSpentOnStepHelp > * CrosFirstRun.TimeSpentOnStepTray > * CrosFirstRun.TutorialCompletion > * CrosFirstRun.TutorialLaunched > > BUG=269291 > > Review URL: https://codereview.chromium.org/131023003 TBR=dzhioev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245903

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+200 lines, -21 lines)			Patch
M	chrome/browser/chromeos/extensions/first_run_private_api.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/first_run/first_run.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/first_run/first_run_controller.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/first_run/first_run_controller.cc	View	7 chunks	+24 lines, -3 lines	0 comments	Download
A	chrome/browser/chromeos/first_run/metrics.h	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/first_run/step.h	View	2 chunks	+21 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/first_run/step.cc	View	2 chunks	+52 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/first_run/step_names.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/first_run/steps/app_list_step.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/first_run/steps/app_list_step.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/first_run/steps/help_step.h	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/first_run/steps/help_step.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/first_run/steps/tray_step.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/first_run/steps/tray_step.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	3 chunks	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

dzhioev (left Google)

6 years, 11 months ago (2014-01-20 12:52:25 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r245903.

Expand Messages | Collapse Messages