chrome/browser/chromeos/extensions/first_run_private_api.cc - Issue 135703003: Merge 245212 "Added UMA metrics for ChromeOS first-run UI."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/first_run_private_api.cc

Issue 135703003: Merge 245212 "Added UMA metrics for ChromeOS first-run UI." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1750/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/extensions/first_run_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/first_run_private_api.cc b/chrome/browser/chromeos/extensions/first_run_private_api.cc

index 4be8e04c8725921386309d49d0bf8416a74cbeb6..b533ec105438d43b1784dfa8564c0e792bd5d8fb 100644

--- a/chrome/browser/chromeos/extensions/first_run_private_api.cc

+++ b/chrome/browser/chromeos/extensions/first_run_private_api.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/chromeos/extensions/first_run_private_api.h"

+#include "base/metrics/histogram.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chromeos/first_run/first_run.h"

#include "chrome/browser/chromeos/login/user_manager.h"

@@ -13,7 +14,8 @@

#include "ui/base/webui/web_ui_util.h"

bool FirstRunPrivateGetLocalizedStringsFunction::RunImpl() {

- DictionaryValue* localized_strings = new DictionaryValue();

+ UMA_HISTOGRAM_COUNTS("CrosFirstRun.DialogShown", 1);

+ base::DictionaryValue* localized_strings = new base::DictionaryValue();

chromeos::User* user =

chromeos::UserManager::Get()->GetUserByProfile(GetProfile());

if (!user->given_name().empty()) {

« no previous file with comments | « no previous file | chrome/browser/chromeos/first_run/first_run.cc » ('j') | no next file with comments »