Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2462)

Unified Diff: chrome/browser/storage/durable_storage_permission_context_unittest.cc

Issue 1356813002: Autogrant the durable storage permission to bookmarked origins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: check that bookmark model exists before using it Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/storage/durable_storage_permission_context_unittest.cc
diff --git a/chrome/browser/storage/durable_storage_permission_context_unittest.cc b/chrome/browser/storage/durable_storage_permission_context_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f4aba3eeacd3fa77ff4f88f9f114ec485985ffc2
--- /dev/null
+++ b/chrome/browser/storage/durable_storage_permission_context_unittest.cc
@@ -0,0 +1,49 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/storage/durable_storage_permission_context.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+using bookmarks::BookmarkModel;
+
+class BookmarksOriginTest : public ::testing::Test {
+ protected:
+ std::vector<BookmarkModel::URLAndTitle> MakeBookmarks(std::string urls[],
jsbell 2015/09/21 17:22:53 nit: static method, const params ?
dgrogan 2015/09/24 20:58:57 Done.
+ int array_size) {
+ std::vector<BookmarkModel::URLAndTitle> bookmarks;
+ for (int i = 0; i < array_size; ++i) {
+ BookmarkModel::URLAndTitle bookmark;
+ bookmark.url = GURL(urls[i]);
+ EXPECT_TRUE(bookmark.url.is_valid());
+ bookmarks.push_back(bookmark);
+ }
+ return bookmarks;
+ }
+};
+
+TEST_F(BookmarksOriginTest, Exists) {
+ std::string urls[] = {
+ "http://www.google.com/",
+ "https://dogs.com/somepage.html",
+ "https://mail.google.com/mail/u/0/#inbox",
+ };
+ std::vector<BookmarkModel::URLAndTitle> bookmarks =
+ MakeBookmarks(urls, arraysize(urls));
+ GURL looking_for("https://dogs.com");
+ EXPECT_TRUE(DurableStoragePermissionContext::IsOriginBookmarked(
+ bookmarks, looking_for));
+}
+
+TEST_F(BookmarksOriginTest, DoesntExist) {
+ std::string urls[] = {
+ "http://www.google.com/",
+ "https://www.google.com/",
+ };
+ std::vector<BookmarkModel::URLAndTitle> bookmarks =
+ MakeBookmarks(urls, arraysize(urls));
+ GURL looking_for("https://dogs.com");
+ EXPECT_FALSE(DurableStoragePermissionContext::IsOriginBookmarked(
+ bookmarks, looking_for));
+}

Powered by Google App Engine
This is Rietveld 408576698