Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/browser/storage/durable_storage_permission_context_unittest.cc

Issue 1356813002: Autogrant the durable storage permission to bookmarked origins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: check that bookmark model exists before using it Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/storage/durable_storage_permission_context.h"
6
7 #include "testing/gtest/include/gtest/gtest.h"
8
9 using bookmarks::BookmarkModel;
10
11 class BookmarksOriginTest : public ::testing::Test {
12 protected:
13 std::vector<BookmarkModel::URLAndTitle> MakeBookmarks(std::string urls[],
jsbell 2015/09/21 17:22:53 nit: static method, const params ?
dgrogan 2015/09/24 20:58:57 Done.
14 int array_size) {
15 std::vector<BookmarkModel::URLAndTitle> bookmarks;
16 for (int i = 0; i < array_size; ++i) {
17 BookmarkModel::URLAndTitle bookmark;
18 bookmark.url = GURL(urls[i]);
19 EXPECT_TRUE(bookmark.url.is_valid());
20 bookmarks.push_back(bookmark);
21 }
22 return bookmarks;
23 }
24 };
25
26 TEST_F(BookmarksOriginTest, Exists) {
27 std::string urls[] = {
28 "http://www.google.com/",
29 "https://dogs.com/somepage.html",
30 "https://mail.google.com/mail/u/0/#inbox",
31 };
32 std::vector<BookmarkModel::URLAndTitle> bookmarks =
33 MakeBookmarks(urls, arraysize(urls));
34 GURL looking_for("https://dogs.com");
35 EXPECT_TRUE(DurableStoragePermissionContext::IsOriginBookmarked(
36 bookmarks, looking_for));
37 }
38
39 TEST_F(BookmarksOriginTest, DoesntExist) {
40 std::string urls[] = {
41 "http://www.google.com/",
42 "https://www.google.com/",
43 };
44 std::vector<BookmarkModel::URLAndTitle> bookmarks =
45 MakeBookmarks(urls, arraysize(urls));
46 GURL looking_for("https://dogs.com");
47 EXPECT_FALSE(DurableStoragePermissionContext::IsOriginBookmarked(
48 bookmarks, looking_for));
49 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698