Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1356673003: Remove unnecessary crashpad:: qualification from implicit_cast<> (Closed)

Created:
5 years, 3 months ago by Mark Mentovai
Modified:
5 years, 3 months ago
Reviewers:
danakj, scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Remove unnecessary crashpad:: qualification from implicit_cast<> This undoes 595803e1be18, a workaround that should no longer be necessary now that base no longer provides implicit_cast<> in the global namespace. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9b9e49d0d9836d91420e1d4a3e5648432f10318d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M util/mac/launchd.mm View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mark Mentovai
Since https://codereview.chromium.org/1340683002/ stuck in Chrome and https://codereview.chromium.org/1347483002/ did the same thing in mini_chromium, this workaround ...
5 years, 3 months ago (2015-09-17 16:31:57 UTC) #2
scottmg
lgtm
5 years, 3 months ago (2015-09-17 17:07:00 UTC) #4
Mark Mentovai
Committed patchset #1 (id:1) manually as 9b9e49d0d9836d91420e1d4a3e5648432f10318d (presubmit successful).
5 years, 3 months ago (2015-09-17 17:11:30 UTC) #5
danakj
5 years, 3 months ago (2015-09-17 17:34:45 UTC) #6
Message was sent while issue was closed.
Thanks :) LGTM

Powered by Google App Engine
This is Rietveld 408576698