Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Side by Side Diff: util/mac/launchd.mm

Issue 1356673003: Remove unnecessary crashpad:: qualification from implicit_cast<> (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 26 matching lines...) Expand all
37 NSDictionary* dictionary_ns = base::mac::CFToNSCast( 37 NSDictionary* dictionary_ns = base::mac::CFToNSCast(
38 base::mac::CFCastStrict<CFDictionaryRef>(property_cf)); 38 base::mac::CFCastStrict<CFDictionaryRef>(property_cf));
39 base::mac::ScopedLaunchData dictionary_launch( 39 base::mac::ScopedLaunchData dictionary_launch(
40 LaunchDataAlloc(LAUNCH_DATA_DICTIONARY)); 40 LaunchDataAlloc(LAUNCH_DATA_DICTIONARY));
41 41
42 for (NSString* key in dictionary_ns) { 42 for (NSString* key in dictionary_ns) {
43 if (![key isKindOfClass:[NSString class]]) { 43 if (![key isKindOfClass:[NSString class]]) {
44 return nullptr; 44 return nullptr;
45 } 45 }
46 46
47 CFPropertyListRef value_cf = crashpad::implicit_cast<CFPropertyListRef>( 47 CFPropertyListRef value_cf =
48 [dictionary_ns objectForKey:key]); 48 implicit_cast<CFPropertyListRef>([dictionary_ns objectForKey:key]);
49 launch_data_t value_launch = CFPropertyToLaunchData(value_cf); 49 launch_data_t value_launch = CFPropertyToLaunchData(value_cf);
50 if (!value_launch) { 50 if (!value_launch) {
51 return nullptr; 51 return nullptr;
52 } 52 }
53 53
54 LaunchDataDictInsert(dictionary_launch, value_launch, [key UTF8String]); 54 LaunchDataDictInsert(dictionary_launch, value_launch, [key UTF8String]);
55 } 55 }
56 56
57 data_launch = dictionary_launch.release(); 57 data_launch = dictionary_launch.release();
58 58
59 } else if (type_id_cf == CFArrayGetTypeID()) { 59 } else if (type_id_cf == CFArrayGetTypeID()) {
60 NSArray* array_ns = base::mac::CFToNSCast( 60 NSArray* array_ns = base::mac::CFToNSCast(
61 base::mac::CFCastStrict<CFArrayRef>(property_cf)); 61 base::mac::CFCastStrict<CFArrayRef>(property_cf));
62 base::mac::ScopedLaunchData array_launch( 62 base::mac::ScopedLaunchData array_launch(
63 LaunchDataAlloc(LAUNCH_DATA_ARRAY)); 63 LaunchDataAlloc(LAUNCH_DATA_ARRAY));
64 size_t index = 0; 64 size_t index = 0;
65 65
66 for (id element_ns in array_ns) { 66 for (id element_ns in array_ns) {
67 CFPropertyListRef element_cf = 67 CFPropertyListRef element_cf =
68 crashpad::implicit_cast<CFPropertyListRef>(element_ns); 68 implicit_cast<CFPropertyListRef>(element_ns);
69 launch_data_t element_launch = CFPropertyToLaunchData(element_cf); 69 launch_data_t element_launch = CFPropertyToLaunchData(element_cf);
70 if (!element_launch) { 70 if (!element_launch) {
71 return nullptr; 71 return nullptr;
72 } 72 }
73 73
74 LaunchDataArraySetIndex(array_launch, element_launch, index++); 74 LaunchDataArraySetIndex(array_launch, element_launch, index++);
75 } 75 }
76 76
77 data_launch = array_launch.release(); 77 data_launch = array_launch.release();
78 78
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 CFCopyTypeIDDescription(type_id_cf)); 132 CFCopyTypeIDDescription(type_id_cf));
133 DLOG(ERROR) << "unable to convert CFTypeID " << type_id_cf << " (" 133 DLOG(ERROR) << "unable to convert CFTypeID " << type_id_cf << " ("
134 << base::SysCFStringRefToUTF8(type_name_cf) << ")"; 134 << base::SysCFStringRefToUTF8(type_name_cf) << ")";
135 } 135 }
136 136
137 return data_launch; 137 return data_launch;
138 } 138 }
139 } 139 }
140 140
141 } // namespace crashpad 141 } // namespace crashpad
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698