Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: Source/core/dom/TreeScope.cpp

Issue 135643004: Make TreeScope::baseURL pure virtual (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/TreeScope.cpp
diff --git a/Source/core/dom/TreeScope.cpp b/Source/core/dom/TreeScope.cpp
index 6bf5ba49941bc47fd422dbe5b1fa525ca4cc5305..44223f13a948892c4cee09be0ac17e0d748b111a 100644
--- a/Source/core/dom/TreeScope.cpp
+++ b/Source/core/dom/TreeScope.cpp
@@ -497,7 +497,7 @@ void TreeScope::setNeedsStyleRecalcForViewportUnits()
KURL TreeScope::completeURL(const String& url) const
{
- return document().completeURLWithOverride(url, baseURL());
+ return document().completeURLWithOverride(url, m_baseURL.isEmpty() ? document().baseURL() : m_baseURL);
esprehn 2014/01/14 00:22:12 Hmm, shouldn't the baseURL getter on ShadowRoot do
adamk 2014/01/14 00:34:03 Very good points. I've added the logic to baseURL
}
} // namespace WebCore
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698