Source/core/dom/TreeScope.cpp - Issue 135643004: Make TreeScope::baseURL pure virtual

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/dom/TreeScope.cpp

Issue 135643004: Make TreeScope::baseURL pure virtual (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All Rights Reserved.	2 * Copyright (C) 2011 Google Inc. All Rights Reserved.

3 * Copyright (C) 2012 Apple Inc. All rights reserved.	3 * Copyright (C) 2012 Apple Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 479 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
490 for (ShadowRoot* root = element->youngestShadowRoot(); root; root = root ->olderShadowRoot())	490 for (ShadowRoot* root = element->youngestShadowRoot(); root; root = root ->olderShadowRoot())

491 root->setNeedsStyleRecalcForViewportUnits();	491 root->setNeedsStyleRecalcForViewportUnits();

492 RenderStyle* style = element->renderStyle();	492 RenderStyle* style = element->renderStyle();

493 if (style && style->hasViewportUnits())	493 if (style && style->hasViewportUnits())

494 element->setNeedsStyleRecalc(LocalStyleChange);	494 element->setNeedsStyleRecalc(LocalStyleChange);

495 }	495 }

496 }	496 }

497	497

498 KURL TreeScope::completeURL(const String& url) const	498 KURL TreeScope::completeURL(const String& url) const

499 {	499 {

500 return document().completeURLWithOverride(url, baseURL());	500 return document().completeURLWithOverride(url, m_baseURL.isEmpty() ? documen t().baseURL() : m_baseURL);
	esprehn 2014/01/14 00:22:12 Hmm, shouldn't the baseURL getter on ShadowRoot do Hmm, shouldn't the baseURL getter on ShadowRoot do this for you? shadowRoot.baseURI from JS should return the Document's URL I think if you haven't assigned anything yet? adamk 2014/01/14 00:34:03 Very good points. I've added the logic to baseURL Show quoted text On 2014/01/14 00:22:12, esprehn wrote: > Hmm, shouldn't the baseURL getter on ShadowRoot do this for you? > > shadowRoot.baseURI from JS should return the Document's URL I think if you > haven't assigned anything yet? Very good points. I've added the logic to baseURL as suggested, and will update the CL description. Please take another look, as I'm not sure you'll like the way I'm avoiding infinite recursion.
501 }	501 }

502	502

503 } // namespace WebCore	503 } // namespace WebCore

OLD	NEW